Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pkg-config webkit version picking #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix pkg-config webkit version picking #83

wants to merge 1 commit into from

Conversation

SpacingBat3
Copy link

@SpacingBat3 SpacingBat3 commented Jan 1, 2025 •
edited
Loading

Description

The current Makefile for login isn't designed right now for cases where user might have multiple versions installed of webkit4.*. Due to this actually being the case for some standard distro envs (Arch-based ones being the example), it's possibly better to additionally sort the grep output and return the last (newest) library version, in order to avoid weird linking issues like with libsoup2 / libsoup3 symbols mixing.

Commit message

Add additional command pipeline to sort and ensure the latest version of webkit4.* is being picked by grep'd pkg-config.

Fixes: #77
Fixes: #80

@SpacingBat3
Copy link
Author

SpacingBat3 commented Jan 1, 2025 •
edited
Loading

Also see #77 for way too much hacky workaround (and I suppose #80 is duplicate to this).

@SpacingBat3
Fix pkg-config webkit version picking
cfc55f1 
Add additional command pipeline to sort and ensure the latest
version of `webkit4.*` is being picked by `grep`'d `pkg-config`.

Fixes: 0xf4b1#77
Fixes: 0xf4b1#80
@SpacingBat3
Copy link
Author

Also, to check if your env makes it possible to reproduce the issues this PR fixes without issuing any compilation at all, you might try this command:

pkg-config --cflags --libs $(pkg-config --list-package-names | grep 'webkit2gtk-4.*') gtk+-3.0 | grep 'lsoup-[0-9.]*' -o

This will print all lsoup versions that will be linked with the current (old) matching rules, hence showing the cause of the issue.

@SpacingBat3
Copy link
Author

Also it looks like that 2d1ce8f introduces the bug, just to narrow the scope of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libsoup-ERROR token creation error (login)
1 participant
@SpacingBat3