Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Br Portuguese doesn't work #3

Closed
GiovanniSalmeri opened this issue Sep 12, 2021 · 9 comments
Closed

Br Portuguese doesn't work #3

GiovanniSalmeri opened this issue Sep 12, 2021 · 9 comments

Comments

@GiovanniSalmeri
Copy link

Installed from IzzyOnDroid, v. 4.4.0 All works flawlessly, except for Br Portuguese: when selected no definition is found (tried with several common protuguese words) and moreover the option for changing the language disappears (I was forced to reinstall). Thank you!

@GiovanniSalmeri GiovanniSalmeri changed the title Br Portuguese doses't work Br Portuguese doesn't work Sep 12, 2021
@103sbavert
Copy link
Owner

Hello, thank you for showing your interest in my app, that means a lot.

Installed from IzzyOnDroid, v. 4.4.0 All works flawlessly, except for Br Portuguese: when selected no definition is found (tried with several common protuguese words)

After doing some debugging I found out about issue: 102. Apparently, this is part of the gradual migration to the new api and support for Portuguese may be dropped from the API. I will try to bring it back but I can't make any promises.

the option for changing the language disappears (I was forced to reinstall). Thank you!

I have fixed the underlying reason but this will no longer be verifiable since I will also be removing support for the languages that don't work until I find a different api that supports more languages.

If you don't mind, I would like to know if you are a Portuguese speaker as that will help me understand if my users really use other languages.

@GiovanniSalmeri
Copy link
Author

Thank you very much for taking the time for this issue. I have read meetDeveloper/freeDictionaryAPI#102 : it would be really unfortunate if support for non-English languages were dropped from the API... I am not a Portuguese speaker (I am Italian), but quite often I read texts in other languages: your app is extremely useful for those who have a limited knowledge of a foreign language, because normally a dictionary entry explains a (unknown) word by means of more common (and known) words. Some minutes after me, also my wife (whose mother tongue is French) installed it!

@103sbavert
Copy link
Owner

I am planning to buy this and if I manage to afford it, I will update my app to use that api and close this issue. If you can help me with donations, feel free to reply, most of us developers are broke students in their teens (or at least so is the case for me).

@GiovanniSalmeri
Copy link
Author

Will the definitions be so complete as now? Trying the box "Enter a word to test the API" at page https://developer.oxforddictionaries.com/ only the first definition presently shown in JADA appears. Anyway, I will gladly contribute if this helps you (and the app 😄)

@103sbavert
Copy link
Owner

103sbavert commented Sep 12, 2021 via email

@GiovanniSalmeri
Copy link
Author

I tried several words, for example "freedom": in JADA five meanings, there only the first.

@103sbavert
Copy link
Owner

103sbavert commented Sep 12, 2021 via email

@103sbavert
Copy link
Owner

@GiovanniSalmeri Apparently, it works fine if you have an api key. This api seems more efficient to me if I manage to buy the developer package. For now I need to build the Pojos and other stuff.

@103sbavert
Copy link
Owner

Mitigated with commit 2308a4c.

JADA 5 supports different languages (Portuguese no longer on the list). Issues like word not found should no longer occur as often with JADA 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants