Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

➕ Add more jokes to the API #5

Open
ABSphreak opened this issue Oct 7, 2020 · 15 comments
Open

➕ Add more jokes to the API #5

ABSphreak opened this issue Oct 7, 2020 · 15 comments
Labels
good first issue Good for newcomers hacktoberfest Hacktoberfest contributions welcomed!

Comments

@ABSphreak
Copy link
Owner

ABSphreak commented Oct 7, 2020 •
edited
Loading

Add more dev jokes to the jokes.json

Please search the JSON for any similar joke.
@ABSphreak ABSphreak added good first issue Good for newcomers hacktoberfest Hacktoberfest contributions welcomed! labels Oct 7, 2020
@karmanya007
Copy link
Contributor

Would like to contribute to some more dev jokes. Btw the jokes already present are so good. 😁

@ABSphreak
Copy link
Owner Author

@karmanya007 sure, go ahead, open up a PR if you've good jokes, please be sure to follow the format in the API.

@karmanya007
Copy link
Contributor

Done!!

@ABSphreak
Copy link
Owner Author

@karmanya007 make the necessary changes in your PR and I'll merge.

@ABSphreak
Copy link
Owner Author

@karmanya007 merged #7, thank you for contributing.

@karmanya007
Copy link
Contributor

Could you please tag this PR with "hacktoberfest-accepted" as as it is showing up as an ineligible PR.

@Jp1200
Copy link
Contributor

Jp1200 commented Oct 7, 2020

Ineligible for Hacktoberfest currently.

@ABSphreak
Copy link
Owner Author

@Jp1200 resolved that.

@ewatch
Copy link
Contributor

ewatch commented Oct 7, 2020

I added PR for this

@irvine09
Copy link
Contributor

irvine09 commented Oct 8, 2020 •
edited
Loading

Added PR too.

Can you please add "hacktoberfest" topic to this repository? @ABSphreak

@AprilShenk AprilShenk mentioned this issue Oct 8, 2020
Merged
@AprilShenk
Copy link

I added a PR for a few jokes.

@ABSphreak ABSphreak changed the title Add more jokes to the API ➕Add more jokes to the API Oct 9, 2020
@ABSphreak ABSphreak changed the title ➕Add more jokes to the API ➕ Add more jokes to the API Oct 9, 2020
@ewatch ewatch mentioned this issue Oct 21, 2020
Merged
@sirkittles
Copy link
Contributor

Added a PR for this.

@EugeneGohh
Copy link
Contributor

Add more dev jokes to the jokes.json

Please search the JSON for any similar joke.

I've opened a PR for this. I updated it on line 751.

@JonathanKarr33 JonathanKarr33 mentioned this issue Apr 19, 2022
Open
@MHFarooqui
Copy link

I opened PR #76 but somehow the build check is failing, please let me know how to correct it. Thanks!!

@AJBrownson
Copy link

Hi guys
I would like to add some jokes to the repo
Is it still open for contributions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest Hacktoberfest contributions welcomed!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@ewatch @ABSphreak @karmanya007 @Jp1200 @sirkittles @AprilShenk @EugeneGohh @MHFarooqui @AJBrownson