Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e Tests for all common app scenarios #2612

Open
5 of 7 tasks
sleidig opened this issue Oct 11, 2024 · 3 comments · May be fixed by #2650
Open
5 of 7 tasks

e2e Tests for all common app scenarios #2612

sleidig opened this issue Oct 11, 2024 · 3 comments · May be fixed by #2650
Assignees
Labels
Client: by X Type: CI & Testing related to devOps, continuous integration and automatic testing

Comments

@sleidig
Copy link
Member

sleidig commented Oct 11, 2024

We currently do not have e2e tests (i.e. "end-to-end" testing of whole scenarios how the user interacts with the app). This means to check if a change breaks existing functionally in other places, we currently click through the app ourselves which takes time and is unreliable. Instead, we should establish automated tests for this again which will also run in the CI of every PR.

  • choose a e2e test framework
    • Playwright seems to gain traction, is supported by angular [>] and has a VS Code plugin to record tests easily [>]
    • Cypres might be an alternative
  • set up the testing framework in our repository
    • i.e. install npm packages, etc.
  • record some basic scenarios as samples
  • discuss with core team and create a list of all the first / most relevant scenarios
  • implement e2e tests for the first scenario
  • enable e2e tests in CI pipelines #2309
  • integrate e2e tests with Percy to add "visual regression testing" [>] (i.e. screenshot comparisons to highlight where the layout changes)

... then continue to gradually add e2e tests for all relevant scenarios: GoogleSheet

@sleidig sleidig added Type: CI & Testing related to devOps, continuous integration and automatic testing Client: by X labels Oct 11, 2024
@github-project-automation github-project-automation bot moved this to Triage / Analysis in All Tasks & Issues Oct 11, 2024
@sleidig sleidig moved this from Triage / Analysis to Todo (ready for work) in All Tasks & Issues Oct 29, 2024
@sadaf895 sadaf895 linked a pull request Nov 6, 2024 that will close this issue
2 tasks
@sleidig sleidig assigned sleidig and tomwwinter and unassigned sleidig Nov 11, 2024
@sleidig sleidig moved this from In Progress to In Review in All Tasks & Issues Nov 11, 2024
@sleidig sleidig moved this from In Progress to In Review in All Tasks & Issues Nov 27, 2024
@sleidig
Copy link
Member Author

sleidig commented Nov 27, 2024

@george-neha will start drafting scenarios for e2e tests:

  • a list of scenarios to be tested
  • steps (fine-grained actions to be tested) within each of the scenarios

@sleidig sleidig moved this from In Review to In Progress in All Tasks & Issues Nov 27, 2024
@george-neha
Copy link

@george-neha george-neha assigned sleidig and unassigned george-neha Dec 13, 2024
@sleidig sleidig moved this from In Progress to In Review in All Tasks & Issues Dec 13, 2024
@sleidig
Copy link
Member Author

sleidig commented Dec 13, 2024

Nice work, @george-neha 👍
Let's focus on implementing the "Attendance" scenario as a first automated e2e test and then take the learnings from that back to the other scenarios.

This looks pretty comprehensive. I guess we might at some point discover an obscure step/feature that is not covered in the scenario yet but it'll be easy to add then and this seems to cover the key functionality.

@sleidig sleidig moved this from In Review to Planned (current "sprint") in All Tasks & Issues Dec 13, 2024
@sleidig sleidig assigned george-neha and unassigned sleidig and tomwwinter Dec 13, 2024
@sleidig sleidig moved this from Planned (current "sprint") to In Progress in All Tasks & Issues Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client: by X Type: CI & Testing related to devOps, continuous integration and automatic testing
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

4 participants