Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit related Public Forms for the current entity type when viewing its AdminEntityComponent #2708

Closed
Tracked by #2271
sleidig opened this issue Dec 9, 2024 · 7 comments · Fixed by #2740
Closed
Tracked by #2271
Assignees
Labels
Client: by X released on @master managed by CI (semantic-release) Type: Improvement Improvement/Extension of existing feature with benefit for the user
Milestone

Comments

@sleidig
Copy link
Member

sleidig commented Dec 9, 2024

see all related Public Forms for the current entity type when viewing its AdminEntityComponent and edit them there. (suggestion: as an additional section in the left-hand menu, below Details View and List View)

@github-project-automation github-project-automation bot moved this to Triage / Analysis in All Tasks & Issues Dec 9, 2024
@sleidig sleidig changed the title see all related Public Forms for the current entity type when viewing its AdminEntityComponent and edit them there. (suggestion: as an additional section in the left-hand menu, below Details View and List View) edit related Public Forms for the current entity type when viewing its AdminEntityComponent Dec 9, 2024
@sleidig sleidig added this to the codo Public Forms milestone Dec 9, 2024
@sleidig sleidig moved this from Triage / Analysis to Todo (ready for work) in All Tasks & Issues Dec 11, 2024
@sleidig sleidig added Type: Improvement Improvement/Extension of existing feature with benefit for the user Client: by X labels Dec 11, 2024
@sleidig sleidig moved this from Todo (ready for work) to Planned (current "sprint") in All Tasks & Issues Dec 16, 2024
@Abhinegi2 Abhinegi2 moved this from Planned (current "sprint") to In Progress in All Tasks & Issues Dec 16, 2024
@Abhinegi2 Abhinegi2 moved this from In Progress to Planned (current "sprint") in All Tasks & Issues Dec 17, 2024
@Abhinegi2 Abhinegi2 moved this from Planned (current "sprint") to In Progress in All Tasks & Issues Dec 17, 2024
@Abhinegi2
Copy link
Contributor

Abhinegi2 commented Dec 17, 2024

@sleidig I wanted to share my initial thoughts or questions regarding this issue:

  • Added a new side tab "Manage Public Form" on the left-hand side in the AdminEntityComponent.
  • On clicking on Manage Public Form use the "RelatedEntities" component to display matching forms related to that entity.
  • Able to edit public form?

@sleidig
Copy link
Member Author

sleidig commented Dec 17, 2024

👍 I think in general it's nice if we need the fewest number of custom components. So maybe indeed we can use the "RelatedEntities" component to display matching public forms and let our standard views handle the rest with the popup screen to edit a specific public form.

@Abhinegi2
Copy link
Contributor

Abhinegi2 commented Dec 18, 2024

👍 I think in general it's nice if we need the fewest number of custom components. So maybe indeed we can use the "RelatedEntities" component to display matching public forms and let our standard views handle the rest with the popup screen to edit a specific public form.

sure going with the same approach, Also updated the approach please have a look now -#2708 (comment)

@Abhinegi2 Abhinegi2 moved this from In Progress to Planned (current "sprint") in All Tasks & Issues Dec 20, 2024
@Abhinegi2 Abhinegi2 moved this from Planned (current "sprint") to In Progress in All Tasks & Issues Dec 26, 2024
@Abhinegi2 Abhinegi2 moved this from In Progress to Functional Review in All Tasks & Issues Dec 27, 2024
@Abhinegi2
Copy link
Contributor

@george-neha Could you test the mentioned requests and review this comment: #2708 (comment)
on the following site: PR-2740?

@Abhinegi2 Abhinegi2 assigned george-neha and unassigned Abhinegi2 Jan 2, 2025
@george-neha
Copy link

george-neha commented Jan 2, 2025

@sleidig @Abhinegi2 In the (child/school/notes)entity, "edit data structure," where the list of all public forms is available, the entity field should be non-editable.
image
Keeping the entity field editable, messes up the configuration of the field in public forms.
image
What do you think?

@sleidig
Copy link
Member Author

sleidig commented Jan 3, 2025

Oh, that's a good find, @george-neha ! This actually will happen anywhere when we change the entity type, not only within the embedded admin section that we discuss in this issue. I have created a separate bug issue for this from your comment: #2770

@sleidig sleidig moved this from Functional Review to Done in All Tasks & Issues Jan 3, 2025
@sleidig sleidig closed this as completed in 8537d86 Jan 3, 2025
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.44.1-master.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client: by X released on @master managed by CI (semantic-release) Type: Improvement Improvement/Extension of existing feature with benefit for the user
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants