Update remove page layout #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary setting/overriding of the page layout in the checkout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary setting/overriding of the page layout in the checkout
Summary
The layout XML explicitly sets the page layout to "checkout". This is unnecessary and should be left to the integrator or custom theme. Because of this attribute, an override on Adyen_Hyva is required while the checkout page layout should not be part of scope of the payment method provider.
Tested scenarios
Customised checkout page layout in the Hyva_Checkout module namespace where it was changed to "1-column". Now it remains "1-column" and isn't overridden by this module.
Fixed issue: #81