Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Pay - buttonRadius prop #3022

Open
strublos opened this issue Dec 13, 2024 · 1 comment
Open

Google Pay - buttonRadius prop #3022

strublos opened this issue Dec 13, 2024 · 1 comment
Labels
Fixed: awaiting confirmation

Comments

@strublos
Copy link

strublos commented Dec 13, 2024 •
edited
Loading

Describe the bug
Setting buttonRadius to zero does not effect.

To Reproduce

  1. Config google pay payment method with prop buttonRadius: 0
  2. Button has default radius.

Expected behavior
Button has 0 radius.

adyen-web version 6.5.0

Additional context
Should be fixed here
https://github.com/Adyen/adyen-web/blob/main/packages/lib/src/components/GooglePay/components/GooglePayButton.tsx#L31

with ...(buttonRadius !== undefined && { buttonRadius })
@longyulongyu longyulongyu added the Confirmed Issue is confirmed and needs fix label Dec 13, 2024
@longyulongyu longyulongyu mentioned this issue Dec 24, 2024
Merged
@sponglord
Copy link
Contributor

@strublos - thanks for raising this issue. It will be fixed in our next v6 release

@sponglord sponglord added Fixed: awaiting confirmation and removed Confirmed Issue is confirmed and needs fix labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed: awaiting confirmation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@strublos @sponglord @longyulongyu