Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] UncorEncounterModel sample and track functions require three specific dynamic variables and fails when acceleration, climb rate, or turn rate is not present #41

Open
aweinert-MIT opened this issue Feb 5, 2022 · 0 comments
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@aweinert-MIT
Copy link
Member

Description

UncorEncounterModel class methods of sample and subsequently track assume the Bayesian network has dynamic variables for acceleration ('\dot v'), climb rate ('\dot h'), and turn rate ('\dot \psi'). While this is true for most models, the unconventional balloon and weather balloon models only have a dynamic variable for climb rate and not for acceleration or turn rate.

Reproducibility

Change RUN_uncor to use the unconventional model parameter file of balloon_v1.txt or weatherballoon_v1.txt. The script will throw an error when calling the sample method of UncorEncounterModel.

parameters_filename = [getenv('AEM_DIR_BAYES') filesep 'model' filesep 'balloon_v1.txt'];

Expectation

Update the UncorEncounterModel class methods of sample and track to handle any combination of dynamic variables of acceleration, climb rate, and turn rate.

Additional

Upon resolving this issue, remove the warning issued by the UncorEncounterModel class constructor for the balloon models.

@aweinert-MIT aweinert-MIT added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed labels Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant