Added support for composer create-project #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 1.x #161 +/- ##
===========================================
- Coverage 77.06% 22.22% -54.84%
===========================================
Files 8 2 -6
Lines 449 27 -422
===========================================
- Hits 346 6 -340
+ Misses 103 21 -82 ☔ View full report in Codecov by Sentry. |
| @@ -53,24 +53,25 @@ jobs: | |||
| sudo chown "$USER" /usr/local/bin/ahoy && chmod +x /usr/local/bin/ahoy | |||
|
|
|||
| - name: Install dependencies | |||
| run: npm ci | |||
| working-directory: .scaffold/tests | |||
| run: composer install | |||
There was a problem hiding this comment.
please do not do this. The whole point was to hide all the scaffold stuff inside of the .scaffold dir so that the consumers can see a clean structure with just one odd directory .scaffold.
Please revert this back and any other overrides.
The task was to only update a couple of fields in composer.json and store everything in .scaffold.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
closes #160
[#123] Verb in past tense with dot at the end.Changedsection about WHY something was done if this was not a normal implementationChanged
Screenshots