Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for markdown.nvim #153

Open
avih7531 opened this issue Aug 2, 2024 · 5 comments
Open

Add Support for markdown.nvim #153

avih7531 opened this issue Aug 2, 2024 · 5 comments
Assignees
Labels
Enhancement New feature, request or suggestion

Comments

@avih7531
Copy link
Contributor

avih7531 commented Aug 2, 2024

I'd like to add support for the rending plugin markdown.nvim -- an awesome, real-time markdown generator for Neovim.

Happy to tackle this one later in the week, but by all means if somebody wants to beat me to it, here are the highlight groups.

Before I start, I would like feedback as to what elements should be which colors? As I'm not a maintainer (happy to become one) I don't provide this project creative direction, and therefore want to make sure that whatever I do truly sticks to @AlexvZyl and @5-pebbles vision. Would love some basic ideas on highlights and color groupings, but will probably make a few and send screenshots before I submit the pull request.

@5-pebbles
Copy link
Collaborator

We already have some basic markup support; I would link to those whenever you can (helps with consistency). You should use utils.blend with palette.bg for the heading background to work with different bgs.

The PR, which added markup support, was fairly recent, and so there are still some things we are figuring out. If you want to change something, you are welcome to try it; just make sure to reflect the changes in the base markup highlights.

@avih7531
Copy link
Contributor Author

avih7531 commented Aug 4, 2024

See #154

@AlexvZyl
Copy link
Owner

AlexvZyl commented Aug 17, 2024

My apologies @5-pebbles and @avih7531. Running work, a startup and my wife's business takes a lot of my time. I think I will take you up on that maintainer offer, if you still want?

Here is my suggestion:
@avih7531 and @5-pebbles prepare releases (do work on dev without me) and then I just review releases when we merge into main. What do you think?

I will obviously still work when I find time. I just find myself to be unreliable.

@AlexvZyl AlexvZyl added the Enhancement New feature, request or suggestion label Aug 17, 2024
@AlexvZyl
Copy link
Owner

AlexvZyl commented Aug 17, 2024

So, basically:

Merging into dev requires one reviewer (you do not have to wait for me) but merging into main requires two reviewers.

I think this theme has a decent number of users so we do not want to break people's work machines. @5-pebbles Those extensive tests you are writing should protect us against that though!

@5-pebbles
Copy link
Collaborator

That sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature, request or suggestion
Projects
None yet
Development

No branches or pull requests

3 participants