Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] allsky.logrotate.repo fails on Bookworm #4109

Open
EricClaeys opened this issue Dec 23, 2024 · 3 comments
Open

[BUG] allsky.logrotate.repo fails on Bookworm #4109

EricClaeys opened this issue Dec 23, 2024 · 3 comments
Assignees
Labels
bug Needs software change In testing Change being tested by the Allsky team

Comments

@EricClaeys
Copy link
Collaborator

EricClaeys commented Dec 23, 2024

The following entries are in the system journal (journalctl --system) on Bookworm.
Haven't checked prior Pi OS's.

Dec 22 00:00:01 allsky logrotate[1042043]: /usr/sbin/invoke-rc.d: 538: /etc/init.d/rsyslog: not found
Dec 22 00:00:01 allsky logrotate[1042040]: invoke-rc.d: initscript rsyslog, action "rotate" failed.
Dec 22 00:00:01 allsky logrotate[1042031]: error: error running shared postrotate script for '/var/log/allsky.log
Dec 22 00:00:01 allsky logrotate[1042031]: '
Dec 22 00:00:02 allsky logrotate[1042050]: /usr/sbin/invoke-rc.d: 538: /etc/init.d/rsyslog: not found
Dec 22 00:00:02 allsky logrotate[1042047]: invoke-rc.d: initscript rsyslog, action "rotate" failed.
Dec 22 00:00:02 allsky logrotate[1042031]: error: error running shared postrotate script for '/var/log/allskyperiodic.log'
@EricClaeys EricClaeys added the bug Needs software change label Dec 23, 2024
@EricClaeys EricClaeys added this to the v2024.12.06_01 milestone Dec 23, 2024
@EricClaeys
Copy link
Collaborator Author

EricClaeys commented Dec 23, 2024

Other scripts have this:

/usr/lib/rsyslog/rsyslog-rotate

whereas allsky.logrotate.repo has:

invoke-rc.d rsyslog rotate > /dev/null

The AI response above has:

systemctl kill -s HUP rsyslog.service

@Alex-developer Alex-developer self-assigned this Dec 26, 2024
@Alex-developer Alex-developer added the In progress Change in progress label Dec 26, 2024
@Alex-developer
Copy link
Collaborator

I have added a couple of fixes to my Allsky and will test them over the next few days before committing them

Alex-developer added a commit that referenced this issue Dec 27, 2024
@Alex-developer
Copy link
Collaborator

Changed logrotate config

Tested over a few days on my pi and is fine

To test this you must set the logs to rotate daily otherwise you will have to wait a week to see if its worked !

Daily rotation

/var/log/allsky.log
{
	rotate 2
	daily
	missingok
	notifempty
	compress
	delaycompress
	sharedscripts
	postrotate
		systemctl kill -s HUP rsyslog.service
	endscript
}

/var/log/allskyperiodic.log
{
	rotate 2
	daily
	missingok
	notifempty
	compress
	delaycompress
	sharedscripts
	postrotate
		systemctl kill -s HUP rsyslog.service
	endscript
}

@Alex-developer Alex-developer added the In testing Change being tested by the Allsky team label Dec 27, 2024
EricClaeys added a commit that referenced this issue Dec 27, 2024
@Alex-developer Alex-developer removed the In progress Change in progress label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Needs software change In testing Change being tested by the Allsky team
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants
@Alex-developer @EricClaeys and others