You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Actually produces a bunch of errors and warnings when PHPCS checks the test cases. These appear to be stylistic constraints like character counts, but I was wondering if I could submit a pull request with these things cleaned up.
I'm not sure if these were left in to demonstrate that the linter works or for some reason that escapes me, but I wouldn't be surprised if someone got confused and thought there were legitimate build errors because of these.
I understand this is a very low priority issue :)
Thanks!
Example Test Response:
FILE: .../php-asana/tests/Asana/Resources/WebhooksTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AND 1 WARNING(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
37 | WARNING | Line exceeds 120 characters; contains 142 characters
41 | ERROR | Line indented incorrectly; expected at least 12 spaces, found
| | 10
--------------------------------------------------------------------------------
The text was updated successfully, but these errors were encountered:
Ha, that is ironic. My guess is that the person who last wrote tests (which, ahem, was me) forgot to run the lint tests before committing the changes. Feel free to submit a pull request if you feel so inspired and we'll pull it in!
Hey, Asana team!
Minor irony but setting things up as shown in the README:
Actually produces a bunch of errors and warnings when PHPCS checks the test cases. These appear to be stylistic constraints like character counts, but I was wondering if I could submit a pull request with these things cleaned up.
I'm not sure if these were left in to demonstrate that the linter works or for some reason that escapes me, but I wouldn't be surprised if someone got confused and thought there were legitimate build errors because of these.
I understand this is a very low priority issue :)
Thanks!
Example Test Response:
The text was updated successfully, but these errors were encountered: