Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Off-By-One Error in Subgraph Generation #6

Open
Jonathan-Rabideau opened this issue Jun 9, 2022 · 0 comments
Open

Off-By-One Error in Subgraph Generation #6

Jonathan-Rabideau opened this issue Jun 9, 2022 · 0 comments

Comments

@Jonathan-Rabideau
Copy link

On line 75 in subgraph_generator.cu, ceil() is useless with integer division.
Should be unsigned int chunkSize = (unsigned int)ceil((double)numActiveNodes / numThreads);

Results in not copying some data to the edge array, sending the old values to the kernel which results in undefined behavior; usually erroneous values in the last .01% of the nodes (but can propagate through the rest of the graph).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant