Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gl.shaderSource is disruptive and doesn't provide enough information #278

Closed
ghost opened this issue Aug 23, 2023 · 1 comment
Closed

gl.shaderSource is disruptive and doesn't provide enough information #278

ghost opened this issue Aug 23, 2023 · 1 comment

Comments

@ghost
Copy link

ghost commented Aug 23, 2023

I have a long (generated) shader and it fails to compile. I'd like to review the shader source. Some observations:

  • shaderSource in Spector.js is very long and it's easy to miss other commands inbetween 2 shaderSource which are huge blocks. The shaderSource log entry should be more minimalistic and show less information.
  • The actual argument to shaderSource is not shown in the log, it's trimmed by "..." so I can't see the complete shader. Ideally, I'd like to open it in the shader editor, just like a shader during draw operations.
  • The actual argument to shaderSource is not shown in the sidebar "Command Arguments" only has 0: WebGLShader - ID: 1 & 1: Array Length: 21858 which isn't very helpful because I still can't review the code.
@sebavan
Copy link
Member

sebavan commented Aug 30, 2023

closing in favor of #283

Spector has never been thought as a tool to help during shader development and it would be great to enhance this area.

@sebavan sebavan closed this as completed Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant