Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making Random a weak dep #289

Open
jakobnissen opened this issue Oct 15, 2023 · 1 comment
Open

Consider making Random a weak dep #289

jakobnissen opened this issue Oct 15, 2023 · 1 comment

Comments

@jakobnissen
Copy link
Member

BioSequences depends on Random, in order to support methods like randdnaseq. Until now, this dependency has been "free", because Random was loaded with Base in the system image, meaning Random was always available.
Starting soon - maybe in Julia 1.11 already, Random will be an external, upgradable package quite similar to ordinary packages. That means it will contribute to latency, and precompilation time. We don't yet know how much latency Random will incur.

We can cut Random as a dependency if we gate methods like shuffle!(::BioSequence) and randseq behind a weak dependency on Random. This will be a breaking change, so let's wait until Random actually is a freestanding stdlib. Nonetheless, I'd support it.

Any opinions? Is this too frivolous a change to release a breaking change?

@kescobo
Copy link
Member

kescobo commented Oct 16, 2023

Seems fine to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants