Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorect "rdfs:subClassOf" in "LabProtocol_v0.8-DRAFT.json" #678

Open
KilianLissSMRTR opened this issue Oct 29, 2024 · 2 comments
Open

Incorect "rdfs:subClassOf" in "LabProtocol_v0.8-DRAFT.json" #678

KilianLissSMRTR opened this issue Oct 29, 2024 · 2 comments

Comments

@KilianLissSMRTR
Copy link

In the following json-ld for LabProtocol:
https://github.com/BioSchemas/specifications/blob/master/LabProtocol/jsonld/LabProtocol_v0.8-DRAFT.json

We have the following:

  "@graph": [
    {
      "@id": "bioschemasdrafts:LabProtocol",
      "@type": "rdfs:Class",
      "rdfs:comment": "Bioschemas profile describing a LabProtocol in Life Sciences. An experimental LabProtocol is a sequence of tasks and operations executed to perform experimental research in biological and biomedical areas. This LabProtocol profile specification presents the markup for describing a LabProtocol type according to Bioschemas. An experimental LabProtocol is a sequence of tasks and operations executed to perform experimental research in biological and biomedical areas. Version 0.8-DRAFT.\n\n<h3>Summary of changes</h3>\nChanges since previous draft 0.7 of the LabProtocols profile:\n<ul>\n<li>Uses LabProtocol draft type 0.4</li>\n<li>Uses name for the name/title of the protocol rather than headline</li>\n<li>Uses intendedUse for the purpose of the protocol</li>\n<li>Moves isPartOf to optional as it is rather generic</li>\n<li>Uses computationalTool rather than sotwareUsed</li>\n</ul>",
      "rdfs:label": "LabProtocol",
      "rdfs:subClassOf": {
        "@id": "bioschemastypesdrafts:LabProtocol"
      },

In particular we have:

"rdfs:subClassOf": {
        "@id": "bioschemastypesdrafts:LabProtocol"
      },

This would suggest that the class LabProtocol is a child class of LabProtocol (which doesn't seem to make sense to me).

In the online documentation:
https://bioschemas.org/profiles/LabProtocol/0.8-DRAFT

The documentation suggests that the class hierarchy should be:
Thing > CreativeWork > HowTo > LabProtocol

Which would suggest that the LabProtocol JSON should be corrected to:

"rdfs:subClassOf": {
 "@id": "schema:HowTo"
},

Please have a look and see if my interpretation is correct, if so, this should be a relative easy fix I would imagine.

@ljgarcia
Copy link
Contributor

Hi @KilianLissSMRTR Thanks for your comment.

Bioschemas has types and profiles. A profile is a recommendation on how to use a specific type (e.g., adding cardinality rules). In both cases, we have drafts and releases. In the case that you mention, we have bioschemastypesdrafts:LabProtocol, meaning a draft type for LabProtocol, and we also have bioschemasdrafts:LabProtocol, meaning a draft profile.

Profiles, as a recommendation over a type, are an rdfs:SubClassOf the corresponding type.

Does it clarify it?

@KilianLissSMRTR
Copy link
Author

KilianLissSMRTR commented Nov 27, 2024

Thanks for the response, it looks like I wasn't including the draft profiles when messing around with the data, hence the hierarchy was a off. It does make sense now though.

I suppose we can close this issue then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants