Skip to content
This repository has been archived by the owner on Sep 25, 2020. It is now read-only.

Windows build fails if path contains spaces #11

Open
rakiru opened this issue Feb 12, 2016 · 3 comments
Open

Windows build fails if path contains spaces #11

rakiru opened this issue Feb 12, 2016 · 3 comments

Comments

@rakiru
Copy link

rakiru commented Feb 12, 2016

When attempting to install Lua, the path isn't quoted, so fails. Everything up to this point correctly quotes paths and works fine.

==> Starting package()...
cd src && mkdir -p C:/Users/Sean/My Documents/Lua/OCEmu/mingw-w64-lua/pkg/mingw-w64-x86_64-lua/mingw64/bin C:/Users/Sean/My Documents/Lua/OCEmu/mingw-w64-lua/pkg/mingw-w64-x86_64-lua/mingw64/include C:/Users/Sean/My Documents/Lua/OCEmu/mingw-w64-lua/pkg/mingw-w64-x86_64-lua/mingw64/lib C:/Users/Sean/My Documents/Lua/OCEmu/mingw-w64-lua/pkg/mingw-w64-x86_64-lua/mingw64/share/man/man1 C:/Users/Sean/My Documents/Lua/OCEmu/mingw-w64-lua/pkg/mingw-w64-x86_64-lua/mingw64/share/lua/5.2 C:/Users/Sean/My Documents/Lua/OCEmu/mingw-w64-lua/pkg/mingw-w64-x86_64-lua/mingw64/lib/lua/5.2
cd src && install -p -m 0755 lua.exe luac.exe lua52.dll C:/Users/Sean/My Documents/Lua/OCEmu/mingw-w64-lua/pkg/mingw-w64-x86_64-lua/mingw64/bin
install: omitting directory ‘C:/Users/Sean/My’
Makefile:61: recipe for target 'install' failed
make: *** [install] Error 1
==> ERROR: A failure occurred in package().
    Aborting...
Failed to build lua

I've confirmed it appears to build correctly on my system in a path without spaces.

@Henny022
Copy link

if there are spaces in the file Path, you have to use quotation marks ("my path"), otherwise the command line thinks, there are two arguments

@gamax92
Copy link
Collaborator

gamax92 commented Dec 3, 2016

So, not too sure how fixable this is, I'm guessing the issue lies in Lua's Makefile, nothing immediately stands out from the MINGW PKGBUILD and patches, I'll look into this though and apologies for the delay.

@LoganDark
Copy link

LoganDark commented Dec 20, 2017

if there are spaces in the file Path, you have to use quotation marks ("my path"), otherwise the command line thinks, there are two arguments

@Henny022 he realized this, and he opened the issue because the path is not quoted. He doesn't have control over whether it's quoted or not (as far as I can tell)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants