Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting tests #117

Open
bleichenbacher-daniel opened this issue May 20, 2024 · 2 comments
Open

Splitting tests #117

bleichenbacher-daniel opened this issue May 20, 2024 · 2 comments

Comments

@bleichenbacher-daniel
Copy link

Another issue where opinions might be very helpful is the question whether some tests should be split into more files. Currently, algorithms for symmetric encryption have just one test file, that mixes tests for encryption and decryption. In other cases (e.g. RSA encryption) test vectors that require indistinguishable behavior during decryption are mixed with test vectors for other purposes. Maybe it would be preferable to split the test files for different purposes (e.g. one for encryption and and one for decryption). It might even make sense to add separate tests for invalid/insecure or otherwise strange parameter selections.

@alex
Copy link
Contributor

alex commented May 20, 2024

As a consumer, I find it helpful if things are split if there's a genuine reason to support one but not the other (e.g., different files for different EC curves), or if the tests are for different things (e.g., different files for signing vs. verification). But other than that, big files are fine.

@bleichenbacher-daniel
Copy link
Author

Makes sense. I think I'm already trying to go in this direction. The upper limit for the file size is about 1 MB, simply because some tools stop displaying or formatting them properly when the files are larger than this limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants