Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crop area chops of bottom of capture window #121

Open
BenedictWilkins opened this issue Sep 24, 2024 · 1 comment
Open

Crop area chops of bottom of capture window #121

BenedictWilkins opened this issue Sep 24, 2024 · 1 comment

Comments

@BenedictWilkins
Copy link
Contributor

The default crop area for windowed capture gets confused by the header bar of the window, it crops of the bottom pixels of the window rather than the window header, as you can see in the image below (I am working on a python binding for this library btw - its plotting the capture in matplotlib).

Screenshot 2024-09-24 175130

If I go in and remove the crop option (force set it to None in scap source - it doesn't work if I provide None to Options...) then it correctly captures the full window (including the header bar). The crop_area option is buggy basically - I can only speak for windows, but it seems like this may be an issue on other platforms, it is a common problem that the reported size of a window by the OS doesn't reflect the actual size of the window + the header bar, this may be the issue.

I am on windows 11 and using the latest github version of scap.

@BenedictWilkins BenedictWilkins changed the title Crop area chops of bottom of capture window on windows machines Crop area chops of bottom of capture window Sep 24, 2024
@BenedictWilkins
Copy link
Contributor Author

BenedictWilkins commented Sep 24, 2024

NOTE: I have updated to use windows crate 0.58, this could be the source of the issue, see if you can reproduce!

EDIT: it could also be an output resolution thing, since it looks like the windows API call is correct...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant