Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HTML Producer] Audio not routed to consumers #669

Open
Julusian opened this issue Jan 10, 2018 · 15 comments · May be fixed by #1517
Open

[HTML Producer] Audio not routed to consumers #669

Julusian opened this issue Jan 10, 2018 · 15 comments · May be fixed by #1517
Assignees
@Julusian
Labels
html type/enhancement

Comments

@Julusian
Copy link
Member

CEF does not appear to support routing of audio, there is a PR to add it but it is stale and not near being merged: https://bitbucket.org/chromiumembedded/cef/pull-requests/18/adding-audio-support/diff
This means that any audio played in it gets sent to the system default soundcard, rather than any audio consumer for the channel. It also means that any audio mixer commands will have no effect.

Once CEF supports routing of audio we should update our html producer to make use of it.
@premultiply
Copy link

Yes, very important feature for HTML template producer.
Thanks for pointing on that.

@mint-dewit mint-dewit mentioned this issue Jan 25, 2018
Closed
@ronag ronag added this to the 3.0.0 milestone Feb 15, 2018
@Julusian
Copy link
Member Author

A new CEF PR has been raised, which replaces the previous one.
https://bitbucket.org/chromiumembedded/cef/pull-requests/151/add-ability-to-redirect-audio-output-to/diff

@premultiply
Copy link

Is it possible to merge that?

@ronag
Copy link
Member

ronag commented Mar 1, 2018

@premultiply we would need a custom CEF build for that.

@Julusian
Copy link
Member Author

Julusian commented Mar 1, 2018

I'm keeping a close eye on it. Once I have some time I intend to test it out in Caspar, but I think its a bit too late to add that into 2.2

@Julusian
Copy link
Member Author

https://bitbucket.org/chromiumembedded/cef/pull-requests/177/add-ability-to-capture-audio-output-to/diff

@Julusian Julusian modified the milestones: 3.0.0, 2.3.0 Jan 25, 2019
@Julusian Julusian mentioned this issue Jan 29, 2019
Closed
@Jgaleas7
Copy link

Any solution for this or any advance?

@Julusian Julusian mentioned this issue Feb 14, 2019
Closed
@Jgaleas7
Copy link

Jgaleas7 commented Mar 7, 2019 •
edited
Loading

https://bitbucket.org/chromiumembedded/cef/pull-requests/177/add-ability-to-capture-audio-output-to/diff
@Julusian
it was DECLINED :(

@Julusian
Copy link
Member Author

Julusian commented Mar 7, 2019

@Jgaleas7 no, it was merged:

Marshall Greenblatt
Manually merged in master revision 58e1149.

https://bitbucket.org/chromiumembedded/cef/commits/58e1149c7127314072903d3d45b9ba8b9fd2fc92

It think that should be available in official CEF builds for Chromium 74. I'll keep an eye out for when builds become available that we can use.

@jesperstarkar
Copy link
Contributor

Oooooooooooooohhhhh!!!!!!!

@Jgaleas7
Copy link

@Jgaleas7 no, it was merged:

Marshall Greenblatt
Manually merged in master revision 58e1149.

https://bitbucket.org/chromiumembedded/cef/commits/58e1149c7127314072903d3d45b9ba8b9fd2fc92

It think that should be available in official CEF builds for Chromium 74. I'll keep an eye out for when builds become available that we can use.

CEF chromium 74 is available http://opensource.spotify.com/cefbuilds/index.html

@Julusian Julusian mentioned this issue Jun 8, 2019
Closed
@Jgaleas7
Copy link

this bug is soved with CEF 71 Current version in master?????

CEF 71 Current version in master #1235

@Julusian
Copy link
Member Author

@Jgaleas7 No, this requires CEF74 but that version introduces other problems so isn't an option for now

@dotarmin dotarmin removed this from the 2.3.0 (deprecated) milestone Apr 6, 2020
@Jgaleas7
Copy link

Jgaleas7 commented Oct 19, 2020 •
edited
Loading

In the version 85 of CEF. I think is solved all problems. Audio route and sharing texture.

@Sidonai-1
Copy link

Any news on this issue?

@Julusian Julusian added the html label Mar 6, 2023
@Julusian Julusian linked a pull request Jan 5, 2024 that will close this issue
feat: route audio from CEF #1517
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Julusian Julusian

Labels
html type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: route audio from CEF CasparCG/server
7 participants
@Julusian @ronag @premultiply @jesperstarkar @Jgaleas7 @dotarmin @Sidonai-1