.minus() dont work

[Piotrex311]

on godot 4.2.2 .minus() do not work

[nhold]

I have tested as well, minus appears to not work when it hits this example:

Actual

10 - 1 = 90

Expected

10 - 1 = 9

and looks to be related to the normalize function:

if big.mantissa < 1.0 or big.mantissa >= 10.0:
		var diff: int = floor(log10(big.mantissa))
		if diff > -10 and diff < 248:
			var div = 10.0 ** diff
			if div > MANTISSA_PRECISION:
				big.mantissa /= div
				big.exponent += diff

From my understanding in this case the mantissa should just equal 9.

It definitely isn't right but I changed to this:

	if big.mantissa == 10.0:
		var diff: int = floor(log10(big.mantissa))
		big.mantissa -= diff
	
	if big.mantissa < 1.0 or big.mantissa > 10.0:
		var diff: int = floor(log10(big.mantissa))
		if diff > -10 and diff < 248:
			var div = 10.0 ** diff
			if div > MANTISSA_PRECISION:
				big.mantissa /= div
				big.exponent += diff

[nhold]

Ah looks like the real solution is here: #32 we should close this issue and link to that.

[ChronoDK]

I don't use Godot 4 myself, so I rely on pull request to keep that version updated for now. In any case I did just commit the suggested solution to this problem - untested, so let me know if it works.