Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cc-ssh-key-list: too much spacing below the first section #1262

Open
florian-sanders-cc opened this issue Dec 2, 2024 · 0 comments
Open
Labels
bug Something isn't working easy-quick-win

Comments

@florian-sanders-cc
Copy link
Contributor

florian-sanders-cc commented Dec 2, 2024

Context

In the first section of the cc-ssh-key-list component, we show text to help people generate their SSH key.

This text is implemented using paragraphs but the last paragraph adds a spacing below that makes the spacing of the first section bigger than typical cc-block-section.

This should be easy to fix:

  • either remove all paragraph margins & use display: grid + gap: 0.5em on their parent,
  • or only set margin-bottom for paragraphs that are not the last with the :not(:last-of-type) selector.

image

@florian-sanders-cc florian-sanders-cc added bug Something isn't working easy-quick-win labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working easy-quick-win
Projects
None yet
Development

No branches or pull requests

1 participant