Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Feat/ajaxforgot #11

Closed
wants to merge 4 commits into from
Closed

[WIP] Feat/ajaxforgot #11

wants to merge 4 commits into from

Conversation

brunooomelo
Copy link

@brunooomelo brunooomelo commented Mar 5, 2020

What's the issue linked?

Resolve #6

Test cases

Report the test cases that you did in list items:

  • Open page
  • added text in input
  • Validation Input
  • Send form
  • Mock endpoint /forgot_password
  • show message success and clear input

Did you test this feature on all browsers?

Yes, tested with all the following browsers:

  • Firefox
  • Chrome

Description

I cloned the ButtonCollab and turned it into a button calling it SubmitCollab. A message of success (MessageCollab) was also created.

@saulonunesdev
Copy link
Contributor

saulonunesdev commented Mar 5, 2020

Hey @brunooomelo thanks for the PR.

One question, should this file be committed?
cypress/videos/pages/Forgot/index.test.js.mp4

@brunooomelo
Copy link
Author

I think so, I looked at the repository and it also exists for signup.

@marcobrunodev
Copy link
Member

@brunooomelo, please make the following changes:

  • change the branch of Feat/ajaxforgot to feature/ajax-forgot;
  • write the commits messages on infinitive, instead of added use add;
  • always use the emojis;
  • always test the interfaces in Firefox and Chrome.

Now I go to make the review code and test interface on my PC.

@brunooomelo
Copy link
Author

Please do not do code review, I will fix some problems found.

@brunooomelo brunooomelo changed the title Feat/ajaxforgot [WIP] Feat/ajaxforgot Mar 5, 2020
@marcobrunodev marcobrunodev deleted the feat/AJAXFORGOT branch March 14, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AJAX Forgot
3 participants