Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUESTION : SELL and BUY swapped? #62

Open
3ntr0phy opened this issue Sep 29, 2021 · 3 comments
Open

QUESTION : SELL and BUY swapped? #62

3ntr0phy opened this issue Sep 29, 2021 · 3 comments

Comments

@3ntr0phy
Copy link

Probably a stupid question but in the first commit the BUY block was in the end and now they are swapped.
Did the logic changed and the comments are old or am I missing something?

@3ntr0phy
Copy link
Author

I guess it is because you changed from SPOT to MARGIN, any specific reason to that?

@3ntr0phy 3ntr0phy changed the title SELL and BUY swapped? QUESTION : SELL and BUY swapped? Sep 29, 2021
@CyberPunkMetalHead
Copy link
Owner

CyberPunkMetalHead commented Sep 29, 2021

It was meant to work as a margin sell but what’s not possible due to several factors, so I will have to revert back to SPOT but in this branch.

If you want to find out how the sell strategy works see it explained here: https://youtu.be/qqXQgwuFI8s

Also, the sell logic has now been moved to its own branch so make sure to check that one out here: https://github.com/CyberPunkMetalHead/binance-trading-bot-new-coins/tree/buy_outside_binance

@3ntr0phy
Copy link
Author

Okay so basically it should be worth reverting back to the previous code - SPOT - for buying and sell right?
Because even in the new branch you shared the order is still margin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants