Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DateOnly parameters #276

Open
tkirill opened this issue Mar 7, 2023 · 2 comments
Open

Support DateOnly parameters #276

tkirill opened this issue Mar 7, 2023 · 2 comments

Comments

@tkirill
Copy link

tkirill commented Mar 7, 2023

Hi!

I'm trying to filter by Date column. Currently I need to manually specify Date type:

new ClickHouseDbParameter { ParameterName = paramName, ClickHouseType = "Date", Value = value };

If I don't specify the type manually then TypeConverter choose DateTime type for DateTime and DateTimeOffset values.

What do you think about supporting DateOnly values and automatically choose Date type for them?

DarkWanderer added a commit that referenced this issue Mar 7, 2023
DarkWanderer added a commit that referenced this issue Mar 7, 2023
@DarkWanderer
Copy link
Owner

Hi. Thank you for your report. This is a trivial change, added for next release

@tkirill
Copy link
Author

tkirill commented Mar 13, 2023

Thank you! Lookng forward for the new release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants