Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found a different way #5

Closed
coderdnewbie opened this issue Oct 15, 2021 · 1 comment
Closed

Found a different way #5

coderdnewbie opened this issue Oct 15, 2021 · 1 comment

Comments

@coderdnewbie
Copy link

Found this in a Microsoft repo

https://github.com/microsoft/FASTER/blob/master/cs/src/core/Utilities/SafeConcurrentDictionary.cs

This is a simpler solution to the atomicity problem but not sure if it needs the lazy wrapped on it, just wanted to share.

@Darkseal
Copy link
Owner

Darkseal commented Oct 16, 2021

Hi @coderdnewbie,

many thanks for your contribution!

MS solutions looks good enough, however I don't think that implementing the SafeConcurrentDictionary will simplify this library: SafeConcurrentDictionary is not in the framework (yet), therefore I would have to either re-implement it or copy/paste the MS code as a separate class, which doesn't seem that great.

Anyway, I'll wait for #4 to close so I can see the best way to update the code to solve the atomicity issue using less code as possible.

@coderdnewbie coderdnewbie changed the title Found a better way Found a different way Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants