support sarif output for scan #259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophetd
force-pushed
the
add-scan-sarif
branch
from
ce6fcba to
8994e12
Compare
christophetd
reviewed
Jul 3, 2023
| @@ -188,3 +188,50 @@ def report_verify_sarif(package_path: str, rule_names: list[str], scan_results: | |||
| runs = get_run(results, driver) | |||
| log = get_sarif_log([runs]) | |||
| return json.dumps(log, indent=2) | |||
|
|
|||
|
|
|||
| def report_scan_sarif(rule_names: list[str], scan_results: list[dict], | |||
There was a problem hiding this comment.
can we add a unit test for it? it seems to be failing for a sample package I tried it on:
$ guarddog pypi scan first-exercise --output-format sarif
File "/Users/christophetd/workspace/guarddog/guarddog/cli.py", line 191, in _scan
return_value = report_scan_sarif(list(ALL_RULES), results, ecosystem)
File "/Users/christophetd/workspace/guarddog/guarddog/reporters/sarif.py", line 211, in report_scan_sarif
"startLine": record["start"]["line"],
TypeError: string indices must be integers
|
Closing following inactivity, feel free to reopen or ask for help if appropriate, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #197
Tested successfully in combination with #257
PS: I think there is a bug in the output format SARIF for the
verifycommand, it does not log all the errors