Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Doctrine DBAL #30

Open
Tracked by #28
schams-net opened this issue Sep 6, 2018 · 2 comments
Open
Tracked by #28

Use Doctrine DBAL #30

schams-net opened this issue Sep 6, 2018 · 2 comments
Labels
enhancement New feature or request Refactoring

Comments

@schams-net
Copy link

schams-net commented Sep 6, 2018 •
edited by DavidBruchmann
Loading

At least the following files contain some kind of $GLOBALS['TYPO3_DB'];, which could (should) be replaced with a proper Doctrine implementation.

Classes/Controller/TopicController.php
Classes/Controller/ForumController.php

Classes/Scheduler/Counter.php
Classes/Scheduler/StatsSummary.php
Classes/Scheduler/Notification.php
Classes/Scheduler/DatabaseMigrator.php
Classes/Scheduler/SessionResetter.php
Classes/Scheduler/ForumRead.php
Classes/Scheduler/DatabaseMigrator.php
Classes/Service/Migration/AbstractMigrationService.php
Classes/Service/Migration/PrivateMessageMigrationService.php
Classes/Service/Migration/ForumMigrationService.php
Classes/Service/Migration/UserGroupMigrationService.php
Classes/Service/Migration/UserMigrationService.php
Classes/Service/Migration/PostsMigrationService.php
Classes/Service/Migration/TopicsMigrationService.php
@DavidBruchmann DavidBruchmann added enhancement New feature or request Refactoring labels Sep 6, 2018
@DavidBruchmann DavidBruchmann mentioned this issue Sep 6, 2018
Open
7 tasks
@schams-net
Copy link
Author

To clarify this issue. EXT:typo3_forum should use TYPO3/Extbase's DB layer (which uses Doctrine), rather than the deprecated $GLOBALS['TYPO3_DB'] construct.

DavidBruchmann added a commit that referenced this issue Nov 3, 2018
@DavidBruchmann
smaller things, also related to #30
cff9098
@DavidBruchmann
Copy link
Owner

removed completely from the stroked classes (see above in issue description)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DavidBruchmann @schams-net