Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v9.5 LTS compat #58

Open
mgrundkoetter opened this issue Feb 8, 2019 · 2 comments
Open

v9.5 LTS compat #58

mgrundkoetter opened this issue Feb 8, 2019 · 2 comments

Comments

@mgrundkoetter
Copy link

This extensions works in v8.7 LTS already, but as v9.5 is the most recent stable LTS, it should be compatible with this, as well. It would be nice to have a branch for this purpose and make pushes/PRs to this.
@mgrundkoetter
Copy link
Author

mgrundkoetter commented Feb 8, 2019 •
edited
Loading

There is also this package: https://github.com/Tuurlijk/typo3scan which makes sharable output:

(see html version on https://codepen.io/mgrundkoetter/full/RvQGNa)

#typo3_forum

Found 83 matches in 52.22s when
checking for changes and deprecations in TYPO3 9

strong weak DEPRECATION BREAKING impossible
89.2% 9.6% 15.7% 84.3% 1.2%

Classes/ViewHelpers/Form/BbCodeEditorViewHelper.php

Usage of class "TYPO3\CMS\Extbase\Object\InvalidClassException" (strong)

109 throw new \TYPO3\CMS\Extbase\Object\InvalidClassException('Expected an implementation of the \Mittwald\Typo3Forum\TextParser\Panel\PanelInterface interface!', 1315835842);

Classes/ViewHelpers/User/AvatarUrlViewHelper.php

Use of static class method call "TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath()" (strong)

72 $avatarFilename = ExtensionManagementUtility::siteRelPath('typo3_forum') . 'Resources/Public/Images/Icons/AvatarEmpty.png';

Classes/ViewHelpers/User/AvatarViewHelper.php

Use of static class method call "TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath()" (strong)

118 $avatarFilename = ExtensionManagementUtility::siteRelPath('typo3_forum') . 'Resources/Public/Images/Icons/AvatarEmpty.png';

Classes/Scheduler/DatabaseMigrator.php

Access to global array "TYPO3_DB" (strong)

113 $this->databaseConnection = $GLOBALS['TYPO3_DB'];

Classes/Scheduler/StatsSummary.php

Access to global array "TYPO3_DB" (strong)

112 $res = $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

113 $row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($res);

Access to global array "TYPO3_DB" (strong)

119 $res = $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

120 $row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($res);

Access to global array "TYPO3_DB" (strong)

127 $res = $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

128 $row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($res);

Access to global array "TYPO3_DB" (strong)

138 $query = $GLOBALS['TYPO3_DB']->INSERTquery('tx_typo3forum_domain_model_stats_summary', $values);

Access to global array "TYPO3_DB" (strong)

139 $GLOBALS['TYPO3_DB']->sql_query($query);

Classes/Scheduler/Counter.php

Access to global array "TYPO3_DB" (strong)

127 $res = $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

128 while ($row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($res)) {

Access to global array "TYPO3_DB" (strong)

136 $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

158 $res = $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

159 while ($row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($res)) {

Access to global array "TYPO3_DB" (strong)

168 $res = $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

169 while ($row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($res)) {

Access to global array "TYPO3_DB" (strong)

178 $res = $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

179 while ($row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($res)) {

Access to global array "TYPO3_DB" (strong)

188 $res = $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

189 while ($row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($res)) {

Access to global array "TYPO3_DB" (strong)

198 $res = $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

199 while ($row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($res)) {

Access to global array "TYPO3_DB" (strong)

207 $res = $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

208 while ($row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($res)) {

Access to global array "TYPO3_DB" (strong)

213 $class = mysqli_real_escape_string($GLOBALS['TYPO3_DB']->getDatabaseHandle(), FrontendUser::class);

Access to global array "TYPO3_DB" (strong)

219 $res = $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

221 while ($row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($res)) {

Access to global array "TYPO3_DB" (strong)

230 $res = $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

232 while ($row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($res)) {

Access to global array "TYPO3_DB" (strong)

267 $query = $GLOBALS['TYPO3_DB']->UPDATEquery('fe_users', 'uid=' . (int)$userUid, $values);

Access to global array "TYPO3_DB" (strong)

268 $res = $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

272 $query = $GLOBALS['TYPO3_DB']->UPDATEquery('tx_typo3forum_domain_model_user_rank', '1=1', ['user_count' => 0]);

Access to global array "TYPO3_DB" (strong)

273 $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

274 $class = mysqli_real_escape_string($GLOBALS['TYPO3_DB']->getDatabaseHandle(), FrontendUser::class);

Access to global array "TYPO3_DB" (strong)

281 $res = $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

282 while ($row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($res)) {

Access to global array "TYPO3_DB" (strong)

283 $query = $GLOBALS['TYPO3_DB']->UPDATEquery(

Access to global array "TYPO3_DB" (strong)

286 $GLOBALS['TYPO3_DB']->sql_query($query);

Classes/Scheduler/ForumRead.php

Access to global array "TYPO3_DB" (strong)

93 $forumRes = $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

94 while ($forumRow = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($forumRes)) {

Access to global array "TYPO3_DB" (strong)

96 $topicRes = $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

98 while ($topicRow = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($topicRes)) {

Access to global array "TYPO3_DB" (strong)

109 $userRes = $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

110 while ($userRow = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($userRes)) {

Access to global array "TYPO3_DB" (strong)

115 $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

123 $query = $GLOBALS['TYPO3_DB']->INSERTquery('tx_typo3forum_domain_model_user_readforum', $insert);

Access to global array "TYPO3_DB" (strong)

124 $GLOBALS['TYPO3_DB']->sql_query($query);

Classes/Scheduler/SessionResetter.php

Access to global array "TYPO3_DB" (strong)

67 $query = $GLOBALS['TYPO3_DB']->UPDATEquery('fe_users', 'pid=' . (int)$this->getUserPid(), $updateArray);

Access to global array "TYPO3_DB" (strong)

68 $res = $GLOBALS['TYPO3_DB']->sql_query($query);

Classes/Scheduler/Notification.php

Access to global array "TYPO3_DB" (strong)

171 $topicRes = $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

173 while ($topicRow = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($topicRes)) {

Access to global array "TYPO3_DB" (strong)

179 $postRes = $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

180 while ($postRow = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($postRes)) {

Access to global array "TYPO3_DB" (strong)

198 $GLOBALS['TYPO3_DB']->exec_INSERTquery('tx_typo3forum_domain_model_user_notification', $insert);

Access to global array "TYPO3_DB" (strong)

217 $tagsRes = $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

219 while ($tagsRow = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($tagsRes)) {

Access to global array "TYPO3_DB" (strong)

226 $userRes = $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

227 while ($userRow = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($userRes)) {

Access to global array "TYPO3_DB" (strong)

235 $postRes = $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

236 while ($postRow = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($postRes)) {

Access to global array "TYPO3_DB" (strong)

252 $GLOBALS['TYPO3_DB']->exec_INSERTquery('tx_typo3forum_domain_model_user_notification', $insert);

Access to global array "TYPO3_DB" (strong)

270 $res = $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

271 $row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($res);

Access to global array "TYPO3_DB" (strong)

288 $res = $GLOBALS['TYPO3_DB']->sql_query($query);

Access to global array "TYPO3_DB" (strong)

289 while ($row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($res)) {

Classes/Controller/AjaxController.php

Fetch of property "uid" (weak)

323 $forum = $this->forumRepository->findByUid($summary->uid);

Fetch of property "uid" (weak)

328 $topic = $this->topicRepository->findByUid($summary->uid);

Classes/Service/Migration/AbstractMigrationService.php

Access to global array "TYPO3_DB" (strong)

63 $this->databaseConnection = $GLOBALS['TYPO3_DB'];

Classes/Service/Mailing/AbstractMailingService.php

Fetch of property "renderCharset" (weak)

112 return $GLOBALS['TSFE']->renderCharset;

Classes/Domain/Repository/User/UserfieldRepository.php

Usage of class "TYPO3\CMS\Extbase\Object\UnknownClassException" (strong)

108 throw new \TYPO3\CMS\Extbase\Object\UnknownClassException("The class $className does not exist!", 1287756385);

Usage of class "TYPO3\CMS\Extbase\Object\UnknownClassException" (strong)

114 throw new \TYPO3\CMS\Extbase\Object\UnknownClassException("The class $className is not a subclass of \Mittwald\Typo3Forum\Domain\Model\User\Userfield\AbstractUserfield", 1287756386);

Classes/Domain/Repository/Forum/TagRepository.php

Call to interface method "like()" (weak)

80 $constraints[] = $query->like('name', '%' . $name . '%', false);

Method "like()" supports only 2 arguments. (weak)

80 $constraints[] = $query->like('name', '%' . $name . '%', false);

Classes/Domain/Model/Forum/ShadowTopic.php

Fetch of property "target" (weak)

51 return $this->target;

Fetch of property "target" (weak)

64 $this->target = $topic;

Classes/Domain/Model/Moderation/ReportWorkflowStatus.php

Use of static class method call "TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath()" (strong)

161 $imageDirectoryName = \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath('typo3_forum') . 'Resources/Public/Images/Icons/Moderation';

Classes/Domain/Factory/Forum/TopicFactory.php

Usage of class "TYPO3\CMS\Extbase\Object\InvalidClassException" (strong)

189 throw new InvalidClassException('Topic is already a shadow topic', 1288702422);

Classes/Ajax/Dispatcher.php

Call to method "checkAlternativeIdMethods()" (weak)

99 $GLOBALS['TSFE']->checkAlternativeIdMethods();

Classes/Utility/File.php

Use of static class method call "TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath()" (strong)

45 return ExtensionManagementUtility::siteRelPath($matches[1]);

Resources/Private/Libraries/GeSHi/contrib/langwiz.php

Syntax error, unexpected T_VARIABLE, expecting T_STRING on line 962 (impossible)

962 \$language_data = array(

@mgrundkoetter
Copy link
Author

mgrundkoetter commented Feb 8, 2019 •
edited
Loading

The default scanner, which ships with v9 mainly states, that all the annotations moved to a separate namespace (@Inject, @Validate, @lazy a.s.o.) and also "Access to array global array "TYPO3_DB"" in several locations. If I remove those, the rest is this:

  • weak: Classes/Ajax/Dispatcher.php Method calculateLinkVars() needs at least 1 arguments.
  • weak: Classes/Ajax/Dispatcher.php Call to method "initFEuser()"
  • weak: Classes/Ajax/Dispatcher.php Call to method "checkAlternativeIdMethods()"
  • weak: Classes/Ajax/Dispatcher.php Call to method "initTemplate()"
  • weak: Classes/Ajax/Dispatcher.php Call to method "getRootLine()"
  • strong: Classes/Ajax/Dispatcher.php Use of static class method call "TYPO3\CMS\Frontend\Utility\EidUtility::initTCA()"
  • weak: Classes/Ajax/Dispatcher.php Fetch of property "sys_page"
  • strong: Classes/Cache/CacheManager.php Call to global constant "PATH_site"
  • weak: Classes/Controller/AjaxController.php Fetch of property "uid"
  • weak: Classes/Controller/AjaxController.php Fetch of property "uid"
  • strong: Classes/Domain/Factory/Forum/TopicFactory.php Usage of class "TYPO3\CMS\Extbase\Object\InvalidClassException"
  • weak: Classes/Domain/Model/Forum/ShadowTopic.php Fetch of property "target"
  • weak: Classes/Domain/Model/Forum/ShadowTopic.php Fetch of property "target"
  • strong: Classes/Domain/Model/Moderation/ReportWorkflowStatus.php Call to global constant "PATH_site"
  • strong: Classes/Domain/Model/Moderation/ReportWorkflowStatus.php Call to global constant "PATH_site"
  • strong: Classes/Domain/Model/Moderation/ReportWorkflowStatus.php Use of static class method call "TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath()"
  • weak: Classes/Domain/Repository/Forum/TagRepository.php Call to interface method "like()"
  • weak: Classes/Domain/Repository/Forum/TagRepository.php Method "like()" supports only 2 arguments.
  • strong: Classes/Domain/Model/User/FrontendUser.php Call to global constant "PATH_site"
  • strong: Classes/Domain/Model/User/FrontendUser.php Call to global constant "PATH_site"
  • strong: Classes/Domain/Repository/User/UserfieldRepository.php Usage of class "TYPO3\CMS\Extbase\Object\UnknownClassException"
  • strong: Classes/Domain/Repository/User/UserfieldRepository.php Usage of class "TYPO3\CMS\Extbase\Object\UnknownClassException"
  • weak: Classes/Scheduler/CounterAdditionalFieldProvider.php Fetch of property "CMD"
  • weak: Classes/Scheduler/CounterAdditionalFieldProvider.php Fetch of property "CMD"
  • weak: Classes/Scheduler/ForumReadAdditionalFieldProvider.php Fetch of property "CMD"
  • weak: Classes/Scheduler/ForumReadAdditionalFieldProvider.php Fetch of property "CMD"
  • weak: Classes/Scheduler/NotificationAdditionalFieldProvider.php Fetch of property "CMD"
  • weak: Classes/Scheduler/NotificationAdditionalFieldProvider.php Fetch of property "CMD"
  • weak: Classes/Scheduler/SessionResetterAdditionalFieldProvider.php Fetch of property "CMD"
  • weak: Classes/Scheduler/SessionResetterAdditionalFieldProvider.php Fetch of property "CMD"
  • weak: Classes/Scheduler/StatsSummaryAdditionalFieldProvider.php Fetch of property "CMD"
  • weak: Classes/Scheduler/StatsSummaryAdditionalFieldProvider.php Fetch of property "CMD"
  • weak: Classes/Service/Mailing/AbstractMailingService.php Fetch of property "renderCharset"
  • weak: Classes/Service/Migration/AbstractMigrationService.php Call to method "addMessage()"
  • weak: Classes/Service/SessionHandlingService.php Call to method "storeSessionData()"
  • strong: Classes/ViewHelpers/Authentication/IfLoggedInViewHelper.php Usage of class "TYPO3\CMS\Fluid\Core\ViewHelper\AbstractViewHelper"
  • strong: Classes/ViewHelpers/Authentication/IfAccessViewHelper.php Usage of class "TYPO3\CMS\Fluid\Core\ViewHelper\AbstractViewHelper"
  • strong: Classes/ViewHelpers/Bootstrap/Form/RowViewHelper.php Usage of class "TYPO3\CMS\Fluid\Core\ViewHelper\AbstractTagBasedViewHelper"
  • strong: Classes/ViewHelpers/Control/PageBrowserViewHelper.php Usage of class "TYPO3\CMS\Fluid\Core\ViewHelper\AbstractViewHelper"
  • strong: Classes/ViewHelpers/Format/FileSizeViewHelper.php Usage of class "TYPO3\CMS\Fluid\Core\ViewHelper\AbstractViewHelper"
  • strong: Classes/ViewHelpers/Format/JsonViewHelper.php Usage of class "TYPO3\CMS\Fluid\Core\ViewHelper\AbstractViewHelper"
  • strong: Classes/ViewHelpers/Forum/RootlineViewHelper.php Usage of class "TYPO3\CMS\Fluid\Core\ViewHelper\AbstractTagBasedViewHelper"
  • strong: Classes/ViewHelpers/Form/BbCodeEditorViewHelper.php Usage of class "TYPO3\CMS\Extbase\Object\InvalidClassException"
  • strong: Classes/ViewHelpers/Forum/ForumIconViewHelper.php Usage of class "TYPO3\CMS\Fluid\Core\ViewHelper\AbstractViewHelper"
  • strong: Classes/ViewHelpers/General/QueryResultReverseViewHelper.php Usage of class "TYPO3\CMS\Fluid\Core\ViewHelper\AbstractViewHelper"
  • strong: Classes/ViewHelpers/Format/TextParserViewHelper.php Usage of class "TYPO3\CMS\Fluid\Core\ViewHelper\AbstractViewHelper"
  • strong: Classes/ViewHelpers/Forum/TopicIconViewHelper.php Usage of class "TYPO3\CMS\Fluid\Core\ViewHelper\AbstractViewHelper"
  • strong: Classes/ViewHelpers/Moderation/ReportIconViewHelper.php Usage of class "TYPO3\CMS\Fluid\Core\ViewHelper\AbstractViewHelper"
  • strong: Classes/ViewHelpers/Social/FacebookShareLinkViewHelper.php Usage of class "TYPO3\CMS\Fluid\Core\ViewHelper\AbstractTagBasedViewHelper"
  • strong: Classes/ViewHelpers/Social/TwitterShareLinkViewHelper.php Usage of class "TYPO3\CMS\Fluid\Core\ViewHelper\AbstractTagBasedViewHelper"
  • strong: Classes/ViewHelpers/Tag/GenerateActionViewHelper.php Usage of class "TYPO3\CMS\Fluid\Core\ViewHelper\AbstractTagBasedViewHelper"
  • strong: Classes/ViewHelpers/User/AvatarViewHelper.php Use of static class method call "TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath()"
  • strong: Classes/ViewHelpers/User/AvatarUrlViewHelper.php Use of static class method call "TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath()"
  • strong: Classes/ViewHelpers/User/LinkViewHelper.php Usage of class "TYPO3\CMS\Fluid\Core\ViewHelper\AbstractViewHelper"
  • strong: Classes/ViewHelpers/User/UserfieldViewHelper.php Usage of class "TYPO3\CMS\Fluid\Core\ViewHelper\AbstractViewHelper"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mgrundkoetter