Remove hard-coded http:// method from TopicController

[schams-net]

Method TopicController::createAction() generates a link with hard-coded http:// method.
File: Classes/Controller/TopicController.php.

This breaks on sites with https:// only (and no redirect from http → https).

[DavidBruchmann]

Simple solution would be:

$this->purgeUrl($_SERVER['REQUEST_SCHEME']. '://' . $_SERVER['HTTP_HOST'] . '/' . $uri);

but I don't know if it's correct in context, or even why it's required at all.

[schams-net]

I have some doubts that this would work reliable to be honest.
For example in setups where a reverse proxy is used and the SSL/TLS endpoint is the proxy server (or CDN):

[INTERNET] --https--> [proxy-and-SSL/TLS-endpoint] --http--> [SERVER]

The HTTP request hitting the [SERVER] is HTTP, but the client accesses the site via HTTPS. Therefore, the link should be https://, too.

A solution could be to take the env variable TYPO3_SSL into account... maybe. But there must be some clever logic in TYPO3 already. Maybe we can use the QueryBuilder?

[DavidBruchmann]

QueryBuilder is for database-connections, I'd prefer UriBuilder or something like that.

[schams-net]

Ah! Of course... sorry... I meant the UriBuilder :-)