Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dendra wof source address incorrect #62

Open
martinseul opened this issue May 2, 2023 · 2 comments
Open

dendra wof source address incorrect #62

martinseul opened this issue May 2, 2023 · 2 comments
Assignees
@cbode @ergjustin

Comments

@martinseul
Copy link

the source address is not correct in dendra wof:

image

I tested this with Justin's compare tool at https://wof-test.netlify.app/, left column hydroportal - right column dendra-wof for site: Catalina-Jemez CZO czo_ariz:Met1 variable: czo_ariz::Temperature2 for 5/1/2012 - 5/2/2012
@ergjustin ergjustin self-assigned this May 2, 2023
@jscottsf
Copy link
Member

jscottsf commented May 3, 2023 •
edited
Loading

Can we get clarification on this? Are we supposed take the individual address parts that are on the source and create a concatenated address, or just passthrough the value on his.odm.sources.Address ? The concatenated address is what's needed so that this works for other stations.

It seems that we may need to put the word "Unknown" in each slot where a value does not exist?

@martinseul
Copy link
Author

this information comes from the source field if unknown or not specified it can be omitted or if needed set to unknown

@cbode cbode self-assigned this May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbode cbode

@ergjustin ergjustin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jscottsf @martinseul @cbode @ergjustin