Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENHANCEMENT: Expose delete_from_target for supported by provider syncs #90

Closed
ViacheslavKudinov opened this issue Jun 18, 2024 · 4 comments

Comments

@ViacheslavKudinov
Copy link
Contributor

Currently when termination of Terraform resources happens, secrets and "resources" will still remain on the target's side.

As it is supported by REST API it will be great to expose for "users" of provider to be able to set delete_from_target when they decide it is safe to have this behavior.
Moreover it is the option on Doppler UI to keep or delete secrets on the target.

So, it will be great to get option to delete secrets of target. Maybe, can be set false by default for the "safety".

@ViacheslavKudinov
Copy link
Contributor Author

In some sense related to #65 as well

@nmanoogian
Copy link
Member

Thanks for the recommendation, @ViacheslavKudinov! Working on this now

@ViacheslavKudinov
Copy link
Contributor Author

Hi,
i think it was addressed by this PR #93
and is there sinse v1.9.0

@nmanoogian
Copy link
Member

Right you are! I must have forgotten to add the "Closes" magic word to that PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants