Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider to adjust the volume of NPC music #107

Open
floral-qua-floral opened this issue Oct 24, 2023 · 1 comment
Open

Slider to adjust the volume of NPC music #107

floral-qua-floral opened this issue Oct 24, 2023 · 1 comment
Assignees

Comments

@floral-qua-floral
Copy link

Some mods which add NPCs with music have the music set up to be pretty loud. I'd be very appreciative if there were a way to reduce the volume without disabling that category of sound entirely. It could replace the "Disable Sound Tracks / Music" checkbox in the Sound Settings menu, or I think it'd also make sense to have it as its own separate thing controlled by a NumSlider in Client Settings. I'm currently putting together a small addon myself which implements such functionality using a terrible hack (I'm replacing the sound.PlayFile function with one that calls the original function, but supplies a modified callback function that tries to figure out if the sound is music and reduces the volume if so), and I figured it would probably make sense to ask here in case you'd be interested in adding that functionality to VJBase itself, since you'd be able to take a much more straightforward approach to the implementation.

@DrVrej DrVrej self-assigned this Oct 25, 2023
@DrVrej
Copy link
Owner

DrVrej commented Oct 25, 2023

Good suggestion! Once everything else in the revamp is finished, I will look into this (Might be a while!)

@DrVrej DrVrej changed the title Suggestion - Slider to adjust the volume of NPC music? Slider to adjust the volume of NPC music Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants