-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Information logger #166
Draft
t-lohse
wants to merge
27
commits into
main
Choose a base branch
from
information-logger
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Information logger #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-lohse
force-pushed
the
information-logger
branch
from
May 22, 2023 08:22
a70b2c8
to
37c8f12
Compare
… into information-logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #165
Fixes #153
This adds a new macro
msg
that either sendsInformation
through gRPC to the client, or prints it to stdout if Reveaal is run in the CLI.This implementation works if no parallelism is implemented on a "deeper level", as it uses
thread::current.id()
to seperate the clients. If this were to change, a new way of handling clients should be implemented. Should I add a todo, or implement a more futureproof version?msg
can be used in a number of ways:I am unsure if it should be so explicit, we could reduce them to look like a function call? (
msg!(severity, subject, message)
)