Skip to content
This repository has been archived by the owner on Mar 19, 2022. It is now read-only.

Change page title #25

Conversation

developer-diganta
Copy link
Member

@developer-diganta developer-diganta commented Nov 5, 2021

Changed the page title to "Event Calendar" (Closes #24 )

README.md Outdated
@@ -2,6 +2,9 @@

This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app).

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/#https://github.com/EddieHubCommunity/EventCalendar)


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@developer-diganta do we need the extra line on line 7?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I guess not. Should I remove it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please @developer-diganta

Copy link
Member

@NS007-dev NS007-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you remove the package.json from your commits?

@developer-diganta
Copy link
Member Author

developer-diganta commented Nov 5, 2021

@CodingSpecies Thank You for pointing it out. I have removed it. I deleted it. But I think this would not work?

@NS007-dev
Copy link
Member

@CodingSpecies Thank You for pointing it out. I have removed it. I deleted it. But I think this would not work?

In the LinkFree repo in EddieHub, the package.json is always altered, so we tell them to take it out of the commits. We will see what the maintainers say. Thank you.

@eddiejaoude
Copy link
Member

Great collaboration 👍

Deleting it is not a good idea, it is best to put it back to what it was, I think you can use

git checkout origin/master package-lock.json

@NS007-dev
Copy link
Member

@eddiejaoude so in this repo do we not need to remove the package.json? Unless it is needed for this pull request?

@eddiejaoude
Copy link
Member

We need to keep the package.json and package-lock.json files in the repo, but people should not commit these unless they made changes to the package.json file

@NS007-dev
Copy link
Member

Ok thank you

@developer-diganta
Copy link
Member Author

Should I change anything or wait for maintainers to instruct?

@eddiejaoude
Copy link
Member

@developer-diganta
Copy link
Member Author

"error: pathspec 'origin/master' did not match any file(s) known to git " I get this error.. What can I do to resolve it?

@mohan-murali
Copy link

"error: pathspec 'origin/master' did not match any file(s) known to git " I get this error.. What can I do to resolve it?

We dont have a master branch. We have a main branch 😄

@developer-diganta
Copy link
Member Author

@mohan-murali Thank you so much for pointing it out! I have done it....

@eddiejaoude
Copy link
Member

Great collaboration everyone.

Thanks for the updates @developer-diganta , we can merge once the package-lock file is removed from the PR

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only include the relevant changes, see my previous comment

@developer-diganta
Copy link
Member Author

Sorry! Got a bit busy with college work.. I wanted to know how to remove the file from the pr?

@eddiejaoude
Copy link
Member

No problem.

I added a comment previously #25 (comment)

@developer-diganta
Copy link
Member Author

@eddiejaoude I have run that command. Is there anything else that I should do?

Copy link

@gptkrsh gptkrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge Conflict

Thank you for your contribution. Your pull request currently has conflicting changes with our main branch. In order to review this pull request, we will need those conflicts to be resolved.

We recommend doing this with the git rebase command. If you are unsure of how to fix this, let us know and we would be happy to assist you.

@gptkrsh
Copy link

gptkrsh commented Nov 20, 2021

@eddiejaoude I have run that command. Is there anything else that I should do?

@developer-diganta An easy way would be to just copy-paste the file from this repo, Created PR: developer-diganta#1

@gptkrsh
Copy link

gptkrsh commented Dec 8, 2021

Hey there @developer-diganta 👋 Just checking in, do you need any help?

Copy link
Member

@Cahllagerfeld Cahllagerfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment

@@ -36161,12 +35863,6 @@
"is-typedarray": "^1.0.0"
}
},
"typescript": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this Lockfile now is fine. It gots cleaned up. Here for some reason is typescript for example

Copy link
Member

@NS007-dev NS007-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@developer-diganta any help needed? This pr has not been very active recently. Thank you.

@developer-diganta
Copy link
Member Author

Sorry! I had not seen this for quite some time now. I think the changes this PR targeted has already been made. Shall I close this PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the title of the page
6 participants