-
-
Notifications
You must be signed in to change notification settings - Fork 43
Change page title #25
Change page title #25
Conversation
README.md
Outdated
@@ -2,6 +2,9 @@ | |||
|
|||
This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app). | |||
|
|||
[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/#https://github.com/EddieHubCommunity/EventCalendar) | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@developer-diganta do we need the extra line on line 7?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I guess not. Should I remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please @developer-diganta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you remove the package.json
from your commits?
@CodingSpecies Thank You for pointing it out. I have removed it. I deleted it. But I think this would not work? |
This reverts commit a4f960b.
…nta/EventCalendar into Change-page-title
In the LinkFree repo in EddieHub, the package.json is always altered, so we tell them to take it out of the commits. We will see what the maintainers say. Thank you. |
Great collaboration 👍 Deleting it is not a good idea, it is best to put it back to what it was, I think you can use
|
@eddiejaoude so in this repo do we not need to remove the package.json? Unless it is needed for this pull request? |
We need to keep the |
Ok thank you |
Should I change anything or wait for maintainers to instruct? |
"error: pathspec 'origin/master' did not match any file(s) known to git " I get this error.. What can I do to resolve it? |
We dont have a master branch. We have a main branch 😄 |
@mohan-murali Thank you so much for pointing it out! I have done it.... |
Great collaboration everyone. Thanks for the updates @developer-diganta , we can merge once the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please only include the relevant changes, see my previous comment
Sorry! Got a bit busy with college work.. I wanted to know how to remove the file from the pr? |
No problem. I added a comment previously #25 (comment) |
@eddiejaoude I have run that command. Is there anything else that I should do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge Conflict
Thank you for your contribution. Your pull request currently has conflicting changes with our main
branch. In order to review this pull request, we will need those conflicts to be resolved.
We recommend doing this with the git rebase
command. If you are unsure of how to fix this, let us know and we would be happy to assist you.
@developer-diganta An easy way would be to just copy-paste the file from this repo, Created PR: developer-diganta#1 |
Hey there @developer-diganta 👋 Just checking in, do you need any help? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment
@@ -36161,12 +35863,6 @@ | |||
"is-typedarray": "^1.0.0" | |||
} | |||
}, | |||
"typescript": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this Lockfile now is fine. It gots cleaned up. Here for some reason is typescript for example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@developer-diganta any help needed? This pr has not been very active recently. Thank you.
Sorry! I had not seen this for quite some time now. I think the changes this PR targeted has already been made. Shall I close this PR? |
Changed the page title to "Event Calendar" (Closes #24 )