Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown HMR sometimes does not work #232

Open
2 tasks done
ouuan opened this issue Feb 5, 2023 · 1 comment
Open
2 tasks done

Markdown HMR sometimes does not work #232

ouuan opened this issue Feb 5, 2023 · 1 comment

Comments

@ouuan
Copy link
Contributor

ouuan commented Feb 5, 2023

Description 📖

When the Markdown <slot> is after some kind (I'm not sure which) of island, its HMR does not work.

Reproduction 🐞

https://github.com/ouuan/iles-issue-232-reproduction

Run pnpm dev and edit src/pages/index.mdx, only the random number changes, and the Markdown content does not change.

If the island and the <slot> are in a reversed order, or client:load is removed, or the prop is a fixed number, the HMR will work.

The real issue is that the HMR in my blog does not work after ouuan/iles-blog@863909c, and I managed to get the above minimal reproduction.
@ElMassimo
Copy link
Owner

Thanks for the report, I'll try to look into it when I have some time.

ouuan added a commit to ouuan/iles-blog that referenced this issue Jul 8, 2023
@ouuan
fix(layouts/post): don't reverse the DOM order of post layout
6529257 
This reverts 863909c.

See ElMassimo/iles#232

I think this fix does not worth the trouble it causes, so revert it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ElMassimo @ouuan