-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding in console to use dev shell #437
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some small changes requested.
|
||
./scripts/init_workspace | ||
|
||
[ -e ../appctl/appctl ] && ./scripts/init_workspace -x ${PWD}/../appctl/appctl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a comment here?
@@ -0,0 +1,24 @@ | |||
#!/usr/bin/env bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should use a set -e
?
scripts/init_workspace
Outdated
@@ -37,7 +37,7 @@ def parse_config(): | |||
""" | |||
config_file = 'scripts/init.cfg' | |||
if not os.path.exists(config_file): | |||
print 'WARNING, no %s found, using possibly outdated configuration' % config_file | |||
print('WARNING, no %s found, using possibly outdated configuration' % config_file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single or double quotes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good.
No description provided.