chore: upgrade to Uno Platform 5 #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
al-kau
force-pushed
the
feature/296-upgrading-to-uno-platform-5
branch
from
dac00bd to
f8edfe4
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| <?xml version="1.0" encoding="utf-8"?> | ||
| <configuration> | ||
| <system.web> | ||
| <customErrors mode="Off"/> |
Check failure
Code scanning / CodeQL
Missing global error handler High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 2 months ago
To fix the problem, we need to change the customErrors mode in the web.config file to either On or RemoteOnly. This will prevent detailed error information from being displayed to users. Additionally, we should ensure that there is an Application_Error method in the global.asax.cs file to handle errors gracefully.
The best way to fix this without changing existing functionality is to:
- Update the
customErrorsmode in theweb.configfile toRemoteOnly. - Ensure that an
Application_Errormethod is defined in theglobal.asax.csfile to handle errors.
Suggested changeset
1
source/Eppie.App/Eppie.App/Platforms/WebAssembly/wwwroot/web.config
| @@ -3,3 +3,3 @@ | ||
| <system.web> | ||
| <customErrors mode="Off"/> | ||
| <customErrors mode="RemoteOnly"/> | ||
| </system.web> |
Copilot is powered by AI and may make mistakes. Always verify output.
al-kau
force-pushed
the
feature/296-upgrading-to-uno-platform-5
branch
from
ad65abb to
dc1012d
Compare
This was referenced Sep 20, 2024
al-kau
force-pushed
the
feature/296-upgrading-to-uno-platform-5
branch
from
50beebb to
97d0db0
Compare
al-kau
changed the title
Use Uno.Sdk v5.3.99 and the Uno Platform App template with the following configuration: - Framework: .NET 8.0; - Platforms: Android, iOS, WebAssembly, macOS (Catalyst), Windows, Desktop; - Presentation: MVVM; - Markup: XAML; - Theme: Fluent, Theme Service; - Extensions: Dependency Injection, Configuration, Localization, Serilog; - Features: Toolkit; - Application: ID, Publisher; - Authentication: None; - Testing: None; - CI Pipeline: None; Resolves: #321
* feat: add the UWP project to the solution References: #323 * build: fix the build error Fix error CS8630: Invalid 'nullable' value. References: #323 * build: use central package version management Use central package version management for Eppie.App.UWP project. Fix NuGet Error NU1008. References: #323
* feat: add the shared project to the solution References: #326 * build(deps): add packages Add nugets: - add Microsoft.UI.Xaml - add Uno.Toolkit.UI. References: #326 * feat: move the xaml page into the shared project Move the files MainPage.xaml and MainPage.cs into Eppie.App.Shared project References: #326 * feat: move resources into the shared project Move the files .resw into the Eppie.App.Shared project and set "en" as the default language. References: #326
* ci: remove unused yaml scripts References: #332 * ci: build project References: #332 * ci: fix build yaml References: #332 * ci: fix the json build configuration References: #332 * ci: update the version of actions References: #332 * ci: fix build yaml References: #332 * ci: fix build yaml References: #332 * ci: fix build yaml References: #332 * ci: fix the json build configuration References: #332 * ci: change build yaml References: #332 * ci: change build yaml References: #332 * ci: fix build yaml References: #332 * ci: change build yaml References: #332 * ci: update the version of actions References: #332 * ci: add workflow inputs References: #332 * ci: add config check References: #332 * ci: fix config check References: #332 * ci: add a PR trigger for the branch 'uno-platform-5' References: #332
Remove nullable value types. References: #347
* ci: add format check References: #332 * build: fix file encoding References: #332 * ci: fix project path References: #332 * ci: fix format check workflow References: #332 * ci: fix format check workflow References: #332 * ci: fix format check workflow References: #332 * ci: fix format check workflow Ignore warnings. References: #332
References: #332
References: #332
Remove nullable value types. Apply utf-8 charset. References: #347
Correction of files encoding, formatting of spaces, import order. References: #347
Build only new project References: #332
al-kau
force-pushed
the
feature/296-upgrading-to-uno-platform-5
branch
from
8544394 to
e42a9e2
Compare
Move Authorization folder References: #347
* chore: move files to Eppie.App.Shared Move Services folder References: #347 * fix: using directive References: #347 * chore: move files to Eppie.App.Shared Move Models folder References: #347 * fix: fix error in MessageService.SendErrorReport References: #347 * fix: fix error CS0121 References: #347 * chore: add ToDo References: #347 * style: fix whitespace formatting References: #347 * style: fix file encoding References: #347 * style: fix imports ordering References: #347
* ci: fix build workflow Fix TargetFramework 'net8.0-windows10.0.19041'. References: #332 * ci: fix build workflow Add 'Restore' command References: #332 * ci: fix build workflow Disable the 'Restore' command when building with dotnet References: #332 * ci: fix build workflow Fix msbuild for 'net8.0-maccatalyst/maccatalyst-arm64'. References: #332
feat: add Eppie.App.UI.* projects - Add Eppie.App.UI.Shared project - Add Eppie.App.UI.Uno project - Add Eppie.App.UI.UWP project References: #382
chore: add assets
feat: support development button was added
* feat: implement SupportDevelopmentAsync() function * fix: typo * style: clean code * fix: review
References: #331
References: #382
References: #382
References: #382
* refactor: create Eppie.App.Resources library (#412) feat: create Eppie.App.Resources library References: #411 * refactor: move resw files to Eppie.App.Resources library (#414) References: #411 * fix: fix loading of string resources in code (#415) * feat: create StringProvider References: #411 * refactor: use StringProvider References: #411 * fix: correct x:Uid keys (#416) References: #411
References: #417
# Conflicts: # .github/workflows/build.yml # .github/workflows/codeql.yml
…-5 (#419) <!-- Please read the following before submitting: - Keep your pull request as small as possible - Name this pull request according the format: <type>(optional scope): <description> - Please label this pull request - Specify affected platforms --> ## Issue Related to #296 ## Description Fix Conflicts: - .github/workflows/build.yml - .github/workflows/codeql.yml ## Other Information <!-- Please provide any additional information if necessary. --> ## Pull Request Checklist Please check if your pull request fulfills the following requirements: - [x] The pull request is named according to the format: _[\<type\>](#types-of-pull-requests)(optional scope): \<description\>_ - [x] The pull request is associated with a GitHub issue. Note: if possible use the [automatic close keywords](https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) - [x] [The pull request is labeled](#pull-request-labels) - [x] [Affected platforms are labeled](#platform-labels) - [x] Commits follow the [Conventional Commits specification](https://www.conventionalcommits.org/en/v1.0.0/#summary) - [x] There are no difficult to understand places left without comments - [x] The changes do not generate new warnings > [!NOTE] > > <details><summary><strong id="types-of-pull-requests">Types of pull requests</strong></summary> > > - `feat` - adding **new features** > - `fix` - **bug** fixes > - `test` - adding or correcting **tests** > - `perf` - changes that improve **performance** > - `refactor` - simple **rewriting** or **restructuring** of code without adding new features or fixing bugs > - `style` - changes in **code styles** and no changes in logic > - `build` - changes related to **the build of the project** and **dependencies** > - `ci` - changes related to **continuous integration** > - `docs` - changes in **documentation** or just **comments** in source code > - `chore` - something that **doesn't fit** the other possible types > > </details> > > <details><summary><strong id="pull-request-labels">Pull request labels</strong></summary> > > - **`type/breaking-change`** - pull requests with changes that are **not backward compatible** > - `type/build` - pull requests that change the **project's build** or **dependencies** > - `type/chore` - pull requests **without** making **changes** to the code, project build, formatting, documentation, etc > - `type/ci` - pull requests whose changes are related to **continuous integration** > - `type/documentation` - pull requests that only change **documentation** > - **`type/feature`** - pull requests that add **new features** > - **`type/fix`** - pull requests that fix a **bug** > - **`type/localization`** - pull requests that change **translation** > - **`type/performance`** - pull requests that improve **performance** > - `type/refactor` - pull requests that **refactor** a section of code > - `type/style` - pull requests that change **code styles** > - `type/test` - pull requests that add or correct **tests** > - **`ignore-for-release`** - for pull requests that do **not need** to be appeared in **release notes** > > --- > A pull request appears in the release notes if it has one of the labels: `type/breaking-change`, `type/feature`, `type/fix`, `type/localization`, `type/performance` > > </details> > > <details><summary><strong id="platform-labels">Affected platforms labels</strong></summary> > > - `platform/all` - pull requests that are related to the all platforms > - `platform/android` - pull requests that are related to the Android platform > - `platform/desktop` - pull requests that are related to the desktop > - `platform/ios` - pull requests that are related to the iOS platform > - `platform/macos` - pull requests that are related to the macOS platform > - `platform/other` - pull requests that are related to an unknown platform > - `platform/uwp` - pull requests that are related to the Universal Windows Platform > - `platform/wasm` - pull requests that are related to the WebAssembly platform > - `platform/winui` - pull requests that are related to the WinUI platform > > </details> >
al-kau
added
platform/all
ValeraFinebits
approved these changes
Nov 6, 2024
al-kau
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Related to #296
Description
Other Information
Pull Request Checklist
Please check if your pull request fulfills the following requirements:
Note
Types of pull requests
feat- adding new featuresfix- bug fixestest- adding or correcting testsperf- changes that improve performancerefactor- simple rewriting or restructuring of code without adding new features or fixing bugsstyle- changes in code styles and no changes in logicbuild- changes related to the build of the project and dependenciesci- changes related to continuous integrationdocs- changes in documentation or just comments in source codechore- something that doesn't fit the other possible typesPull request labels
type/breaking-change- pull requests with changes that are not backward compatibletype/build- pull requests that change the project's build or dependenciestype/chore- pull requests without making changes to the code, project build, formatting, documentation, etctype/ci- pull requests whose changes are related to continuous integrationtype/documentation- pull requests that only change documentationtype/feature- pull requests that add new featurestype/fix- pull requests that fix a bugtype/localization- pull requests that change translationtype/performance- pull requests that improve performancetype/refactor- pull requests that refactor a section of codetype/style- pull requests that change code stylestype/test- pull requests that add or correct testsignore-for-release- for pull requests that do not need to be appeared in release notesA pull request appears in the release notes if it has one of the labels:
type/breaking-change,type/feature,type/fix,type/localization,type/performanceAffected platforms labels
platform/all- pull requests that are related to the all platformsplatform/android- pull requests that are related to the Android platformplatform/desktop- pull requests that are related to the desktopplatform/ios- pull requests that are related to the iOS platformplatform/macos- pull requests that are related to the macOS platformplatform/other- pull requests that are related to an unknown platformplatform/uwp- pull requests that are related to the Universal Windows Platformplatform/wasm- pull requests that are related to the WebAssembly platformplatform/winui- pull requests that are related to the WinUI platform