Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block-section fails to attach CSS icon--end class #11053

Open
2 of 6 tasks
Elijbet opened this issue Dec 13, 2024 · 0 comments
Open
2 of 6 tasks

block-section fails to attach CSS icon--end class #11053

Elijbet opened this issue Dec 13, 2024 · 0 comments
Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library

Comments

@Elijbet
Copy link
Contributor

Elijbet commented Dec 13, 2024

Check existing issues

Actual Behavior

This line fails to attach CSS class to iconEnd when both iconStart and iconEnd props are present.
https://github.com/Esri/calcite-design-system/blob/dev/packages/calcite-components/src/components/block-section/block-section.tsx#L155

Screenshot 2024-12-12 at 12 38 07 PM

When corrected, add themed tests for the following tokens:

"--calcite-block-section-text-color-hover"
// {
// shadowSelector: .${CSS.iconEnd},
// targetProp: "color",
// state: "hover",
// },
--calcite-block-section-text-color
// TODO: bug CSS.iconEnd doesn't properly apply on the element
// { shadowSelector: .${CSS.iconEnd}, targetProp: "color" },

Expected Behavior

CSS.iconEnd should apply when end icon is present.

Reproduction Sample

https://codepen.io/elijbet/pen/oNORWGX?editors=1010

Reproduction Steps

  • Populate props for both iconStart and iconEnd in block-section.
  • Open Inspect
  • Observe both render as icon--start.

Reproduction Version

2.13.2

Relevant Info

No response

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)

@Elijbet Elijbet added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 13, 2024
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. labels Dec 13, 2024
@Elijbet Elijbet changed the title block-section fails to attach CSS icon--end class when both iconStart and iconEnd props are present block-section fails to attach CSS icon--end class Dec 13, 2024
@github-actions github-actions bot added the impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive label Dec 13, 2024
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library estimate - 2 Small fix or update, may require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Development

No branches or pull requests

2 participants