Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus State Behavior for v3 List Items Appears Unexpected #11078

Open
AdamWMoqrane opened this issue Dec 17, 2024 · 3 comments
Open

Focus State Behavior for v3 List Items Appears Unexpected #11078

AdamWMoqrane opened this issue Dec 17, 2024 · 3 comments
Labels
0 - new New issues that need assignment. ArcGIS Knowledge Issues logged by ArcGIS Knowledge team members. ArcGIS Web Analysis Issues logged by ArcGIS Web Analysis team members bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 5 A few days of work, definitely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - medium Issue is non core or affecting less that 60% of people using the library

Comments

@AdamWMoqrane
Copy link

AdamWMoqrane commented Dec 17, 2024

Description

The focus states for v3 List components are inconsistent, leading to alignment issues and unexpected focus behavior. This problem seems related to the structure of the component and the keyboard navigation of each "table cell" within the List. This issue persists even when using the icon-start property introduced in 3.0.

User Stories

As a product designer working with List components, I want the focus states to be standardized and consistent so that users have a predictable and accessible experience when navigating through list items.

Acceptance Criteria

  • The focus behavior for List components works consistently across all focusable areas (icon, label, and actions).
  • Misalignment issues caused by fractional pixel rendering or hitbox inconsistencies are resolved.
  • Keyboard navigation within "table cells" behaves as expected.
  • Switching to the content-start or icon-start slots does not introduce misaligned or unintended focus behavior.

Relevant Info

  • Repro Steps:
    1. Use icon-start with v3 List components.
    2. Observe the focus states and alignment when interacting with the List items.
  • Codepen Example: Link to Codepen provided by @adam
  • Additional Observations: Misalignment appears fractional depending on the component's internal structure and click targets.

Helpful Details

  • The icons were placed in the default content-start slots, which exacerbates the misalignment issues.
  • Swapping to the icon-start slot improves alignment slightly but does not completely resolve focus behavior.
  • Conversations referenced:
    • Adam Moqrane, Adam Tirella, Paul Coster, Aaron Shetland (see screenshots).

Priority impact

impact - p1 - need for current milestone

Esri team

ArcGIS Knowledge

@AdamWMoqrane AdamWMoqrane added 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. new component Issues tied to a new component. labels Dec 17, 2024
Copy link
Contributor

cc @ashetland, @SkyeSeitz, @brittneytewks

@github-actions github-actions bot added ArcGIS Knowledge Issues logged by ArcGIS Knowledge team members. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Dec 17, 2024
@ashetland
Copy link

ashetland commented Dec 17, 2024

@geospatialem I think this focus behavior should be categorized as a bug and I think it's been with us for while. I believe this is the focus state in question where only the content area is focused:

image

Ideally, focus should only be on the entire item or interactive elements, such as the drag handle, close button, or slotted actions.
image
image

@geospatialem geospatialem added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. p - medium Issue is non core or affecting less that 60% of people using the library estimate - 5 A few days of work, definitely requires updates to tests. and removed new component Issues tied to a new component. needs triage Planning workflow - pending design/dev review. labels Dec 17, 2024
@geospatialem
Copy link
Member

Confirmed with @ashetland this has been occurring for a while, at least since 2.6 and in our latest 2.13, but this is something we'd like to address ASAP, ideally for 3.0, but if not, shortly thereafter.

image

@ashetland ashetland added the ArcGIS Web Analysis Issues logged by ArcGIS Web Analysis team members label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Knowledge Issues logged by ArcGIS Knowledge team members. ArcGIS Web Analysis Issues logged by ArcGIS Web Analysis team members bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 5 A few days of work, definitely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Development

No branches or pull requests

3 participants