Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[label] enhance labelClickHandler to ignore events that are prevented #11100

Open
2 of 5 tasks
driskull opened this issue Dec 18, 2024 · 0 comments
Open
2 of 5 tasks

[label] enhance labelClickHandler to ignore events that are prevented #11100

driskull opened this issue Dec 18, 2024 · 0 comments
Assignees
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.

Comments

@driskull
Copy link
Member

Check existing issues

Description

Should the following code honor preventDefault?

private labelClickHandler(event: MouseEvent): void {
if (window.getSelection()?.type === "Range") {
return;
}
this.calciteInternalLabelClick.emit({
sourceEvent: event,
});
}

Acceptance Criteria

This would allow any click events within a component to not call setFocus to the component because the label click event

Relevant Info

No response

Which Component

all label-able components

Example Use Case

No response

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

N/A

@driskull driskull added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 18, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

2 participants