Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[List Item] Extend bottom border to the beginning of the actions-start slot #11115

Open
2 of 5 tasks
eriklharper opened this issue Dec 19, 2024 · 0 comments
Open
2 of 5 tasks

[List Item] Extend bottom border to the beginning of the actions-start slot #11115

eriklharper opened this issue Dec 19, 2024 · 0 comments
Assignees
@eriklharper
Labels
2 - in development Issues that are actively being worked on. ArcGIS Web Analysis Issues logged by ArcGIS Web Analysis team members Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone
Milestone
2025-01-30 - 3.0....

Comments

@eriklharper
Copy link
Contributor

eriklharper commented Dec 19, 2024 •
edited
Loading

Check existing issues

Description

List item was redesigned to move the bottom border just underneath the content, but the recent change left out the actions-start slot.

Acceptance Criteria

Bottom border extends under the actions-start slot.

Relevant Info

No response

Which Component

list-item

Example Use Case

No response

Priority impact

impact - p1 - need for current milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Web Analysis
@eriklharper eriklharper added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 19, 2024
@eriklharper eriklharper self-assigned this Dec 19, 2024
@eriklharper eriklharper added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 19, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Dec 19, 2024
@eriklharper eriklharper mentioned this issue Dec 19, 2024
Merged
@ashetland ashetland added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 19, 2024
@github-actions github-actions bot added the ArcGIS Web Analysis Issues logged by ArcGIS Web Analysis team members label Dec 19, 2024
@eriklharper eriklharper added the estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. label Dec 19, 2024
eriklharper added a commit that referenced this issue Dec 20, 2024
@eriklharper
feat(list-item): extend bottom border to include actions-start slot (#…
1553fc5 
…11116)

**Related Issue:** #11115

## Summary

This extends the bottom border of `list-item` content to include content
in the `actions-start` slot.

BEGIN_COMMIT_OVERRIDE
omitted from changelog
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eriklharper eriklharper

Labels
2 - in development Issues that are actively being worked on. ArcGIS Web Analysis Issues logged by ArcGIS Web Analysis team members Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone
Projects
None yet
Milestone
2025-01-30 - 3.0.0 Jan Breaking Chang...
Development

No branches or pull requests
3 participants
@eriklharper @geospatialem @ashetland