Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] Fix iOS React Native error 'value' is unavailable #18653

Closed
neil-marcellini opened this issue May 9, 2023 · 19 comments
Closed

[$1000] Fix iOS React Native error 'value' is unavailable #18653

neil-marcellini opened this issue May 9, 2023 · 19 comments
Assignees
Labels
External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Monthly KSv2

Comments

@neil-marcellini
Copy link
Contributor

neil-marcellini commented May 9, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Problem

With the latest Xcode installed, when you run npm run ios it fails with the error 'value' is unavailable: introduced in iOS 12.0

Importance

All developers needs to be able to easily run the App on iOS. The workarounds for now are to downgrade to an older version of Xcode or manually set the iOS Deployment target to iOS 13.0 for the React-Codegen Pod, as described here. These workarounds are time consuming and we don't want to have to do them forever.

To be clear this is a dev only error, not a bug with the App

Solution

Upgrade our react native installation to at least 0.71.6 which will fix this error.

Issue reported by: @neil-marcellini

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0180b96036d141f4c5
  • Upwork Job ID: 1655979058433728512
  • Last Price Increase: 2023-05-09
@neil-marcellini neil-marcellini added Daily KSv2 Improvement Item broken or needs improvement. Bug Something is broken. Auto assigns a BugZero manager. labels May 9, 2023
@neil-marcellini neil-marcellini self-assigned this May 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 9, 2023

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented May 9, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@neil-marcellini neil-marcellini added the External Added to denote the issue can be worked on by a contributor label May 9, 2023
@melvin-bot melvin-bot bot changed the title Fix iOS React Native error 'value' is unavailable [$1000] Fix iOS React Native error 'value' is unavailable May 9, 2023
@neil-marcellini neil-marcellini added the Weekly KSv2 label May 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 9, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0180b96036d141f4c5

@neil-marcellini neil-marcellini removed the Daily KSv2 label May 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 9, 2023

Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 9, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 9, 2023

Current assignee @neil-marcellini is eligible for the External assigner, not assigning anyone new.

@neil-marcellini neil-marcellini removed Help Wanted Apply this label when an issue is open to proposals by contributors Bug Something is broken. Auto assigns a BugZero manager. labels May 9, 2023
@neil-marcellini
Copy link
Contributor Author

This isn't actually a bug but I wanted to use the label temporarily to kick start the process with external contributors. I think a contributor can fix this.

@aimane-chnaif
Copy link
Contributor

If upgrading RN fixes the issue, there's already PR

@neil-marcellini
Copy link
Contributor Author

Awesome thanks for linking that @aimane-chnaif! I figured maybe that was already in the works. I'll hold on the upgrade issue and we can retest once it's done.

@melvin-bot melvin-bot bot added the Overdue label May 12, 2023
@s77rt
Copy link
Contributor

s77rt commented May 12, 2023

Not overdue.
@neil-marcellini Can you add the "HOLD" to the title?

@melvin-bot melvin-bot bot removed the Overdue label May 12, 2023
@zoontek zoontek mentioned this issue May 14, 2023
54 tasks
@melvin-bot melvin-bot bot added the Overdue label May 15, 2023
@flaviadefaria
Copy link
Contributor

@neil-marcellini when put this on hold can you also switch it to weekly?

@melvin-bot melvin-bot bot removed the Overdue label May 15, 2023
@neil-marcellini
Copy link
Contributor Author

Oh yeah on it, I must have gotten distracted last time.

@neil-marcellini neil-marcellini changed the title [$1000] Fix iOS React Native error 'value' is unavailable [HOLD 18444][$1000] Fix iOS React Native error 'value' is unavailable May 15, 2023
@neil-marcellini neil-marcellini added Weekly KSv2 and removed Daily KSv2 labels May 15, 2023
@flaviadefaria
Copy link
Contributor

I'm OoO for 8 days so re-adding the BUG label, but keeping myself assigned. I'll be back at work on May 30th if this needs to be actioned before I'm back please re-apply the bug label.

@melvin-bot melvin-bot bot added the Overdue label May 29, 2023
@s77rt
Copy link
Contributor

s77rt commented May 29, 2023

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label May 29, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 6, 2023
@neil-marcellini
Copy link
Contributor Author

ditto

@melvin-bot melvin-bot bot removed the Overdue label Jun 6, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 15, 2023
@neil-marcellini
Copy link
Contributor Author

Holding, I'm making this a monthly.

@melvin-bot melvin-bot bot removed the Overdue label Jun 16, 2023
@neil-marcellini neil-marcellini added Monthly KSv2 and removed Weekly KSv2 labels Jun 16, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 18, 2023
@neil-marcellini
Copy link
Contributor Author

Still on hold, there's progress.

@melvin-bot melvin-bot bot removed the Overdue label Jul 18, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2023
@s77rt
Copy link
Contributor

s77rt commented Aug 23, 2023

#18444 is now resolved. I think we can close this.

@melvin-bot melvin-bot bot removed the Overdue label Aug 23, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 25, 2023
@neil-marcellini neil-marcellini changed the title [HOLD 18444][$1000] Fix iOS React Native error 'value' is unavailable [$1000] Fix iOS React Native error 'value' is unavailable Sep 25, 2023
@neil-marcellini
Copy link
Contributor Author

Oh awesome, yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Monthly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants