Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Login - here link in suspended account message is invalid

What is the root cause of that problem?

The link used to point to community.expensify.com discussion, but since we now are move to help.expensify.com, we need to update the link.

What changes do you think we should make in order to solve the problem?

We will change the link here:

We should maybe point it to the Email-Notifications.md page 🤔 or as the team decides.

@alexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Proposal

Please re-state the problem that we are trying to solve in this issue.

• When the user click on 'authenticator app link' the redirected website throws an error

What is the root cause of that problem?

• When open the link to here text, the below link will be opened:
  

  App/src/pages/signin/EmailDeliveryFailurePage.tsx

  Line 56 in 840c227

  href="https://community.expensify.com/discussion/5651/deep-dive-best-practices-when-youre-running-into-trouble-receiving-emails-from-expensify/p1?new=1"

• In PR, we already have a logic to redirect app to https://help.expensify.com/articles/expensify-classic/settings/account-settings/Set-Notifications (targetURL) in case of https://community.expensify.com/discussion/5651/deep-dive--practices-when-youre-running-into-trouble-receiving-emails-from-expensify (sourceURL):

but there are a few problem with that link:

1. In here, the sourceURL is ...deep-dive--practices...: It is a typo issue, it should be ...deep-dive-best-practices....
2. In here, the sourceURL does not contain /p1?new=1, but the link in here does.

Both of the above reasons leads to our current bug, where the here link is not equal to the sourceURL link in the sourceURL-targetURL pair.

What changes do you think we should make in order to solve the problem?

• We should update the link in line:
  

  App/src/pages/signin/EmailDeliveryFailurePage.tsx

  Line 56 in 840c227

  href="https://community.expensify.com/discussion/5651/deep-dive-best-practices-when-youre-running-into-trouble-receiving-emails-from-expensify/p1?new=1"

  directly:

                            href="https://help.expensify.com/articles/expensify-classic/settings/account-settings/Set-Notifications"

What alternative solutions did you explore? (Optional)

• We need to move the link here to the CONST:

SET_NOTIFICATION_LINK  =  "https://community.expensify.com/discussion/5651/deep-dive--practices-when-youre-running-into-trouble-receiving-emails-from-expensify"

and then use it as href={SET_NOTIFICATION_LINK}

• Finally, update the csv file to fix 2 errors i mentioned in RCA section to make sure the SET_NOTIFICATION_LINK is equal to the sourceURL in:

Job added to Upwork: https://www.upwork.com/jobs/~021866332376780918197

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

@allgandalf - Can you please review and confirm if one of these proposals will fix the issue? Thanks!

I will review today

Heads up, I will be offline until Wednesday, December 18, 2024, and will not actively watch over this GitHub during that period.

If this GitHub requires an urgent update, please ask for help in the #expensify-open-source Slack Room. If the inquiry can wait, I'll review it when I return online.

@allgandalf - please keep us posted if one of these proposals will fix the issue. Thanks!

Will review tomorrow

Lets go with @truph01's proposal here, their RCA is correct and solution should work

Note for internal engineer : Should we go with their Alternative solution ? We move all the community.expensify.com links to CONST file currently, so that alternative solution would also work

🎀👀🎀 C+ reviewed

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

📣 @truph01 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

Note for internal engineer : Should we go with their Alternative solution ? We move all the community.expensify.com links to CONST file currently, so that alternative solution would also work

@allgandalf @truph01 Let's follow the typical pattern in that case

@allgandalf PR is ready

♻️ Update: PR has been merged

Weekly Update: Waiting for automation

I just created a follow-up PR here

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.78-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: update here link in suspended account message #54230

If no regressions arise, payment will be issued on 2025-01-02. 🎊

For reference, here are some details about the assignees on this issue:

• @allgandalf requires payment automatic offer (Reviewer)
• @truph01 requires payment automatic offer (Contributor)

@allgandalf @alexpensify @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Heads up, I will be offline until Friday, January 3, 2024, and will not actively watch over this GitHub during that period.

@allgandalf and @truph01, I will complete the payment process when I return on Friday, January 3. If you would like the payment issued sooner, please post this issue in #expensify-open-source, and someone on the team will jump in. Please be aware that we have a limited number of team members online, so there might be a delayed response. Thanks!

enjoy your time off @alexpensify , it's okay from my side to hold payment for a bit 👍