[MOD: Cry of Fear] Excedding VGUI_MAX_TEXTURES 1024 limits will cause killing server.

[TheKingFireS]

Anything that used VGUI, best case is hovering cursor on inventory item icon.

Info:
Patch version: 1.55 (1.2 and 1.0 untested)
Xash3D-FWGS: e751092
OS: Windows 10 x86_64bit
GPU: GTX 1650
Custom renderer: Enabled
Map: Any

[nekonomicon]

It's knowledge bug, CoF has a big memory leak in inventory code, even 1.6 version.

[TheKingFireS]

I have stupid idea, make environment variable named I_WANT_MEMORY_LEAK that allow unlimited amount of VGUI_MAX_TEXTURES instead of limited 1024. Because Goldsrc let vgui memory leak pass without stop, until it crash.

[a1batross]

It won't help that much because there is MAX_TEXTURES limit in the engine.

[a1batross]

Well, I made a dead simple deduplicator by taking MD5 from texture data, and then looking up if any of the textures have the same hash. It helps to avoid hitting MAX_TEXTURES limit in the engine and potentially leaking VRAM.

The problem is that we cannot deduplicate the texture IDs we sent to VGUI. We might reallocate the array until some hard limit, and after that the engine will refuse loading any new VGUI textures, thus avoiding Host_Error, potential crash and also letting Cry of Fear leak memory all it wants.

[a1batross]

Fixed by d6ebff8