Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not auto resume after the call is over #1316

Open
moshiur-raj opened this issue Mar 28, 2022 · 4 comments · May be fixed by #1318
Open

Do not auto resume after the call is over #1316

moshiur-raj opened this issue Mar 28, 2022 · 4 comments · May be fixed by #1318
Labels
enhancement A request for a feature or additional functionality UX User Experience

Comments

@moshiur-raj
Copy link

GSConnect currently automatically resumes the media when a call is over. Whenever someone calls me I have to put my headphone down and pick up the phone and as soon as the call is over the media auto resumes. So I miss a couple seconds of the video / audio. Then I have to rewind the media. There should be an option for choosing not to auto resume the media.
@ferdnyc ferdnyc added enhancement A request for a feature or additional functionality UX User Experience labels Mar 30, 2022
@ferdnyc
Copy link
Member

ferdnyc commented Mar 30, 2022

I thought this was a great idea, so I implemented it. Opening a PR for the changes.

@ferdnyc ferdnyc linked a pull request Mar 30, 2022 that will close this issue
Open
@moshiur-raj
Copy link
Author

Thank you!

@Etaash-mathamsetty
Copy link

a delay would be nice too...

@ferdnyc
Copy link
Member

ferdnyc commented Apr 1, 2022

@Etaash-mathamsetty

My only concern there is that a delay is useless unless it's configurable, and I'm wary of adding that sort of complexity to the process. Along with other complications. If there's a delay, then we have to account for things like...:

  1. An incoming call arrives before the delay expires
  2. The user makes a new outgoing call before the delay expires
  3. The user manually unpauses a player before the delay expires
  4. The user changes the state of their media apps (quits one / launches another) during the delay period
  5. etc...

I'm not absolutely opposed to the idea, so this isn't a "no". But it's at least a "maybe, but not yet".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A request for a feature or additional functionality UX User Experience
Projects
None yet
Milestone
No milestone
3 participants
@ferdnyc @moshiur-raj @Etaash-mathamsetty