Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is breaking on archaic downloads #2166

Open
sauclovian-g opened this issue Dec 19, 2024 · 2 comments
Open

CI is breaking on archaic downloads #2166

sauclovian-g opened this issue Dec 19, 2024 · 2 comments
Labels
tech debt Issues that document or involve technical debt test assets Issues involving test programs or other test assets tooling: CI Issues involving CI/CD scripts or processes type: bug Issues reporting bugs or unexpected/unwanted behavior
Milestone

Comments

@sauclovian-g
Copy link
Contributor

The "Test s2n proofs" jobs in the CI for awslc and blst (but not apparently others) are failing because they're trying to download (and then not use, we think/hope) some ancient build results that just got purged from the saw website.

They need to be made to not do that.

@sauclovian-g sauclovian-g added type: bug Issues reporting bugs or unexpected/unwanted behavior tech debt Issues that document or involve technical debt tooling: CI Issues involving CI/CD scripts or processes test assets Issues involving test programs or other test assets labels Dec 19, 2024
@sauclovian-g sauclovian-g added this to the 2025T1 milestone Dec 19, 2024
@sauclovian-g
Copy link
Contributor Author

This has been bodged so it doesn't fail by putting the ancient build results back; an actual fix is needed.

@RyanGlScott
Copy link
Contributor

Now that I look more closely at this, I think that there is actually a relatively straightforward workaround available. This is because the awslc Dockerfile doesn't clone the upstream version of aws-lc-verification, but rather our own fork of it:

RUN mkdir -p /saw-script && \
git clone https://github.com/GaloisInc/aws-lc-verification.git && \
cd aws-lc-verification && \
git checkout 9e9dde6882ade1f5d01c6d088e6dcca181358a74 && \

That commit is on this branch. As such, we could push a commit to this branch that removes the use of the nightly SAW download (here).

We can do something similar for blst job given that we own the https://github.com/GaloisInc/BLST-Verification repo. All we'd have to do is make sure that we don't download a nightly versions of things (see the code here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Issues that document or involve technical debt test assets Issues involving test programs or other test assets tooling: CI Issues involving CI/CD scripts or processes type: bug Issues reporting bugs or unexpected/unwanted behavior
Projects
None yet
Development

No branches or pull requests

2 participants