Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use coroutine scope instead of using runBlocking for rejoining #1267

Closed
wants to merge 2 commits into from

Conversation

skydoves
Copy link
Member

@skydoves skydoves commented Jan 3, 2025

🎯 Goal

Use coroutine scope instead of using runBlocking for rejoining

🛠 Implementation details

Since runBlocking blocks the entire Android main thread and occupies it until the coroutine scope is completed, it can lead to ANRs or prevent the UI from rendering properly.

@skydoves skydoves self-assigned this Jan 3, 2025
@skydoves skydoves requested a review from a team as a code owner January 3, 2025 03:27
@skydoves
Copy link
Member Author

skydoves commented Jan 6, 2025

Closing - The prepareRejoin() function will eventually be invoked inside the worker thread from the call site; the consideration will not happen for now.

@skydoves skydoves closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants