[Fix]Missing tracks #507
[Fix]Missing tracks #507
Conversation
Generated by 🚫 Danger |
| var updatedParticipants = self.participants | ||
|
|
||
| guard | ||
| participant.sessionId != sessionID, |
There was a problem hiding this comment.
hmm, but if we exclude the current participant, how are we going to update their track visibility?
There was a problem hiding this comment.
That's an interesting one. Let me discuss the 2 different things we are doing here:
-
Update track.isEnabled
By doing that on the local user ... it disables the track which means that we are not sending any more data to remote participants. I have no idea yet why that was working before. -
Update participant.showTrack
I have that disabled for now as it's causing some flickering that i need to investigate (probably due to something causing multiple redraws)
There was a problem hiding this comment.
- Update track.isEnabled: but isn't it expected that we don't send any more data if the flag is false?
ipavlidakis
force-pushed
the
feature/reconnection-v2
branch
from
1e4964d to
6224a22
Compare
ipavlidakis
force-pushed
the
reconnection-v2/missing-tracks
branch
from
6ab22af to
a69c4f9
Compare
SDK Size
|
ipavlidakis
force-pushed
the
feature/reconnection-v2
branch
from
210e99b to
feda9bc
Compare
ipavlidakis
force-pushed
the
reconnection-v2/missing-tracks
branch
2 times, most recently
from
570fba3 to
a346d07
Compare
ipavlidakis
force-pushed
the
reconnection-v2/missing-tracks
branch
from
a346d07 to
4184a43
Compare
|
🔗 Issue Links
Provide all JIRA tickets and/or GitHub issues related to this PR, if applicable.
🎯 Goal
Describe why we are making this change.
📝 Summary
Provide bullet points with the most important changes in the codebase.
🛠 Implementation
Provide a detailed description of the implementation and explain your decisions if you find them relevant.
🎨 Showcase
Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.
imgimg🧪 Manual Testing Notes
Explain how this change can be tested manually, if applicable.
☑️ Contributor Checklist
🎁 Meme
Provide a funny gif or image that relates to your work on this pull request. (Optional)