Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for WebRTCStateMachine stages #522

Merged
merged 5 commits into from
Sep 13, 2024
Merged

Add tests for WebRTCStateMachine stages #522

merged 5 commits into from
Sep 13, 2024

Conversation

ipavlidakis
Copy link
Collaborator

@ipavlidakis ipavlidakis commented Sep 12, 2024 •
edited
Loading

📝 Summary

This PR adds comments and test coverage on the WebRTCCoodinator StateMachine+Stages.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (Docusaurus, tutorial, CMS)

@ipavlidakis ipavlidakis changed the title WIP Add tests for WebRTCStateMachine stages Sep 12, 2024
@ipavlidakis ipavlidakis self-assigned this Sep 12, 2024
@ipavlidakis ipavlidakis added the enhancement New feature or request label Sep 12, 2024
@ipavlidakis ipavlidakis added this to the Reconnection v2 milestone Sep 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Sep 12, 2024 •
edited
Loading

SDK Size

title develop branch diff status
StreamVideo 7.4 MB 7.85 MB +455 KB 🟡
StreamVideoSwiftUI 2.18 MB 2.18 MB -2 KB 🚀
StreamVideoUIKit 2.32 MB 2.31 MB -2 KB 🚀
StreamWebRTC 8.69 MB 8.69 MB 0 KB 🟢

@ipavlidakis ipavlidakis force-pushed the reconnection-v2/webrtc-statemachine-add-docs-and-tests branch from 2c67174 to 10051e6 Compare September 13, 2024 11:07
@ipavlidakis ipavlidakis force-pushed the reconnection-v2/webrtc-statemachine-add-docs-and-tests branch from 10051e6 to 964adbc Compare September 13, 2024 11:17
@ipavlidakis ipavlidakis marked this pull request as ready for review September 13, 2024 11:17
@ipavlidakis ipavlidakis requested a review from a team as a code owner September 13, 2024 11:17
martinmitrevski
martinmitrevski approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ✅ Added few small comments

Sources/StreamVideo/WebRTC/v2/StateMachine/Stages/WebRTCCoordinator+Leaving.swift Outdated Show resolved Hide resolved
Sources/StreamVideo/WebRTC/v2/WebRTCConfiguration.swift Outdated Show resolved Hide resolved
StreamVideoTests/WebRTC/SFU/Mocks/MockSFUAdapter.swift Outdated Show resolved Hide resolved
StreamVideoTests/WebRTC/SFU/SFUEventAdapter_Tests.swift Outdated Show resolved Hide resolved
@ipavlidakis ipavlidakis merged commit 583f5fb into feature/reconnection-v2 Sep 13, 2024
1 check passed
@ipavlidakis ipavlidakis deleted the reconnection-v2/webrtc-statemachine-add-docs-and-tests branch September 13, 2024 14:07
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
110 New issues
0 Accepted issues

Measures
0 Security Hotspots
76.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ipavlidakis added a commit that referenced this pull request Sep 18, 2024
@ipavlidakis
Add tests for WebRTCStateMachine stages (#522)
62c53da
ipavlidakis added a commit that referenced this pull request Sep 19, 2024
@ipavlidakis
Add tests for WebRTCStateMachine stages (#522)
99a6d3f
ipavlidakis added a commit that referenced this pull request Sep 24, 2024
@ipavlidakis
Add tests for WebRTCStateMachine stages (#522)
f657938
ipavlidakis added a commit that referenced this pull request Sep 24, 2024
@ipavlidakis
Add tests for WebRTCStateMachine stages (#522)
cad3346
ipavlidakis added a commit that referenced this pull request Sep 26, 2024
@ipavlidakis
Add tests for WebRTCStateMachine stages (#522)
5de8964
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

@ipavlidakis ipavlidakis

Labels
enhancement New feature or request
Projects
None yet
Milestone
Reconnection v2
Development

Successfully merging this pull request may close these issues.
3 participants
@ipavlidakis @Stream-SDK-Bot @martinmitrevski